Handle term definition on @type with empty map.
#369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlongley
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Approving, but I agree with @davidlehn that this should be an invalid term definition error.
It's "keyword redefinition" as that is the case for any attempt to change a keyword, other than specific carve-outs for |
gkellogg
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes expand#tec02 & toRdf#tec02.
@gkellogg "keyword redefinition" was not what I expected for this type of error. Is that more appropriate than the more generic "invalid term definition"?