Remove rdf-canonize-native support #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all support for rdf-canonize-native bindings to simplify the codebase and reduce maintenance overhead. The JavaScript implementation provides sufficient performance for most use cases and eliminates the complexity of native dependencies. - Remove native package loading and initialization - Remove useNative option and _rdfCanonizeNative API - Remove native test cases from test suite - Update documentation to remove native references - Clean up package.json browser/react-native configurations Co-Authored-By: Claude <[email protected]>
tminard
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Thank you!
@davidlehn @dlongley can one of you take a look as well? It looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all support for
rdf-canonize-nativebindings from the library, implementing the plan outlined by the maintainer in digitalbazaar/jsonld.js#567.Motivation
As stated by @davidlehn in digitalbazaar/jsonld.js#567:
The native bindings add maintenance complexity while providing limited performance benefits with modern JavaScript runtimes.
Changes
useNativeoption and_rdfCanonizeNativeAPIpackage.jsonbrowser/react-native configurationsTesting
The JavaScript-only implementation maintains full compatibility with the RDF canonicalization specification while simplifying the codebase.
Breaking Changes
This is a breaking change for users who were explicitly using the
useNative: trueoption. However, given that:This change aligns with the project's stated direction and reduces maintenance burden.