Test Reorganization (and two bugfixes)#14
Merged
syjer merged 4 commits intodigitalfondue:mainfrom Dec 21, 2025
Merged
Conversation
Separate cases into folders by category and use parameterized tests to automatically run new tests
Member
|
Hi @maths22 , thank you again for the pr. I'll have a look tomorrow. For the test reorganization: good idea to use parameterized tests 👍 |
Member
|
Thank you for the PR, I'll do a release during next week :) |
Contributor
Author
|
@syjer Would it be possible to get a release cut with these fixes in it? |
Member
|
@maths22 , sure. I'll do it today :). Then this weekend I'll do a release with the mj-html-attributes implementation. |
Member
|
@maths22 release has been done. Thank you again for your contributions :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the tests to be driven by the files that exist in the repository
so that adding a new test case is a matter of simply adding an mjml file to the
appropriate directory. This PR then uses that reorganized framework to fix two minor
bugs that I had previously noticed and worked around.
I'm happy to split the PR into two PRs, or get rid of the test organization part and
just submit the bugfix part. When I was doing the upgrade PR I realized the java part of the tests
was almost all the same and therefore seemed like a good use-case for parameterized tests,
but I understand if that isn't how you want to manage them in this project.