Skip to content

Fix renderFilter form accumulating duplicate filter parameters #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix renderFilter form accumulating duplicate filter parameters #2175

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
571b682
Initial plan
Copilot Dec 11, 2025
3712a19
Fix renderFilter adding multiple filter= parameters to URL
Copilot Dec 11, 2025
1a2ac60
Refactor to eliminate code duplication in renderFilter
Copilot Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ihp/IHP/Pagination/ViewFunctions.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ renderFilter :: (?context::ControllerContext) =>
-> Html
renderFilter placeholder =
[hsx|
<form method="GET" action="" class="mt-2 float-right">
<form method="GET" action={formAction} class="mt-2 float-right">
<div class="form-row">
<div class="col-auto">
<label class="sr-only" for="inlineFormInput">Name</label>
Expand All @@ -156,10 +156,11 @@ renderFilter placeholder =
</form>
|]
where
path = Wai.rawPathInfo theRequest
formAction = path
boxValue = fromMaybe "" (paramOrNothing "filter") :: Text
clearFilterUrl = path <> Query.renderQuery True newQueryString
where
path = Wai.rawPathInfo theRequest
queryString = Wai.queryString theRequest
newQueryString = queryString
|> removeQueryItem "filter"
Expand Down