Make Logger functional with bracket-style resource management #2247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify Logger from a 5-field record (write, level, formatter, timeCache, cleanup) to a 2-field record (log, level). The log closure bakes in level checking, formatting, and time caching at construction time. Cleanup is handled externally via bracket rather than stored on the Logger itself. - Remove LoggerSettings, its Default instance, and defaultDestination - newLogger takes 4 explicit args, returns (Logger, IO ()) tuple - Add withLogger/withDefaultLogger for bracket-style resource management - Add configureLogger helper for user-facing config in Config.hs - buildFrameworkConfig returns (FrameworkConfig, IO ()) to thread cleanup - Update all call sites: ScriptSupport, Migrate, DevServer, Migrations, ModelSupport, SchemaMigration, Hspec, Mocking, and test files - Update Guide/logging.markdown for new API Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Loggerfrom a 5-field record (write,level,formatter,timeCache,cleanup) to a 2-field record (log,level) — thelogclosure bakes in level checking, formatting, and time caching at construction timeLoggerSettings, itsDefaultinstance, anddefaultDestinationin favor of explicitnewLoggerarguments and a newconfigureLoggerconfig helperwithLogger/withDefaultLogger) instead of storing it on the Logger, withbuildFrameworkConfigthreading cleanup out asIO (FrameworkConfig, IO ())Test plan
IHP/Log/Types.hscompiles standalone viaghci🤖 Generated with Claude Code