Add stream chunk collection if evaluation-id is passed#15
Merged
tgillam-do merged 2 commits intomainfrom Jan 6, 2026
Merged
Conversation
dillonledoux
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that if evaluation-id is passed that the chunks are collected and returned at once along with the trace-id. This fixes an issue where evaluations would not work properly if responses were being streamed.
Testing
Tested locally with a streaming agent and validated that trace id comes back properly.
Added integration tests for testing streaming with and without evaluation-id header.