Fix concurrency issues #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused request_id field from CapturedRequest (simplified from complex UUID correlation) - Simplify _record_response to use single URL-based matching (foolproof for HTTP call boundaries) - Simplify _record_request to return void (unused return value removed) - Clean up imports and add __slots__ to CapturedRequest for memory efficiency - Remove _ensure_state helper and simplify _get_state - Update tests to match simplified API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug previously where maintaining a global state of traces resulted in mis-matched traces during concurrent requests. This change ensure that each request gets a separate trace object and ensures that concurrent requests work fine.
Validated with a 50 query test file with 5 concurrency.
Also removed examples/ folder as it is redundant with gradient-adk-templates.