Remove popup when switching environments (#204) + fix general refresh button

Author: MykolaYaremchuk

ide-common/src/main/java/org/digma/intellij/plugin/analytics/Environment.java

@@ -5,7 +5,6 @@
 import org.apache.commons.lang3.time.StopWatch;
 import org.digma.intellij.plugin.common.Backgroundable;
 import org.digma.intellij.plugin.log.Log;
-import org.digma.intellij.plugin.notifications.NotificationUtil;
 import org.digma.intellij.plugin.persistence.PersistenceData;
 import org.digma.intellij.plugin.settings.SettingsState;
 import org.digma.intellij.plugin.ui.model.environment.EnvironmentsSupplier;
@@ -248,7 +247,7 @@ private void notifyEnvironmentChanged(String oldEnv, String newEnv) {
         if (project.isDisposed()) {
             return;
         }
-        NotificationUtil.notifyChangingEnvironment(project, oldEnv, newEnv);
+        Log.log(LOGGER::info, "Digma: Changing environment " + oldEnv + " to " + newEnv);
         EnvironmentChanged publisher = project.getMessageBus().syncPublisher(EnvironmentChanged.ENVIRONMENT_CHANGED_TOPIC);
         publisher.environmentChanged(newEnv);
     }

ide-common/src/main/java/org/digma/intellij/plugin/document/DocumentInfoContainer.java

@@ -62,15 +62,15 @@ public void update(@NotNull DocumentInfo documentInfo) {
         //maybe documentInfo already exists, override it anyway with a new one from analysis
         this.documentInfo = documentInfo;
 
-        loadAllInsightsForCurrentEnvironment();
+        loadAllInsightsForCurrentDocument();
     }
 
     public void refresh() {
         Log.log(LOGGER::debug, "Refreshing document backend data for {}: ", psiFile.getVirtualFile());
-        loadAllInsightsForCurrentEnvironment();
+        loadAllInsightsForCurrentDocument();
     }
 
-    public List<CodeObjectInsight> getMethodInsights(@NotNull MethodInfo methodInfo) {
+    public List<CodeObjectInsight> getMethodInsightsFromCache(@NotNull MethodInfo methodInfo) {
         Log.log(LOGGER::debug, "Requesting insights for MethodInfo {}", methodInfo.getId());
 
         return insights.stream().filter(codeObjectInsight -> {
@@ -82,8 +82,8 @@ public List<CodeObjectInsight> getMethodInsights(@NotNull MethodInfo methodInfo)
         }).collect(Collectors.toList());
     }
 
-    private void loadAllInsightsForCurrentEnvironment() {
-        List<String> objectIds = getObjectIds();
+    private void loadAllInsightsForCurrentDocument() {
+        List<String> objectIds = getObjectIdsForCurrentDocument();
         try {
             Log.log(LOGGER::debug, "Requesting insights with ids {}", objectIds);
             insights = analyticsService.getInsights(objectIds);
@@ -108,7 +108,7 @@ private void loadAllInsightsForCurrentEnvironment() {
         }
     }
 
-    private List<String> getObjectIds() {
+    private List<String> getObjectIdsForCurrentDocument() {
         return this.documentInfo.getMethods().values().stream().flatMap((Function<MethodInfo, Stream<String>>) methodInfo -> {
             var ids = new ArrayList<String>();
             ids.add(methodInfo.idWithType());

ide-common/src/main/java/org/digma/intellij/plugin/insights/InsightsProvider.java

@@ -5,7 +5,6 @@
 import org.apache.commons.lang3.time.StopWatch;
 import org.digma.intellij.plugin.analytics.AnalyticsService;
 import org.digma.intellij.plugin.analytics.AnalyticsServiceException;
-import org.digma.intellij.plugin.document.DocumentInfoContainer;
 import org.digma.intellij.plugin.document.DocumentInfoService;
 import org.digma.intellij.plugin.insights.view.BuildersHolder;
 import org.digma.intellij.plugin.insights.view.InsightsViewBuilder;
@@ -45,12 +44,8 @@ public InsightsListContainer getInsights(@NotNull MethodInfo methodInfo) {
         var stopWatch = StopWatch.createStarted();
 
         try {
-            DocumentInfoContainer documentInfoContainer = documentInfoService.getDocumentInfo(methodInfo.getContainingFileUri());
-            List<? extends CodeObjectInsight> codeObjectInsights = new ArrayList<>();
-            if (documentInfoContainer != null) {
-                codeObjectInsights = documentInfoContainer.getMethodInsights(methodInfo);
-                codeObjectInsights = filterUnmapped(codeObjectInsights);
-            }
+            List<? extends CodeObjectInsight> codeObjectInsights = analyticsService.getInsights(objectIds);
+            codeObjectInsights = filterUnmapped(codeObjectInsights);
             Log.log(LOGGER::debug, "CodeObjectInsights for {}: {}", methodInfo.getId(), codeObjectInsights);
             final UsageStatusResult usageStatus = analyticsService.getUsageStatus(objectIds);
             InsightsViewBuilder insightsViewBuilder = new InsightsViewBuilder(buildersHolder);

ide-common/src/main/kotlin/org/digma/intellij/plugin/ui/service/InsightsViewService.kt

@@ -165,7 +165,7 @@ class InsightsViewService(project: Project) : AbstractViewService(project) {
 
     }
 
-    fun refreshInsights() {
+    fun refreshAllInsights() {
         val scope = model.scope
         if (scope is MethodScope) {
             Backgroundable.ensureBackground(project, "Refresh insights list") {

java/src/main/java/org/digma/intellij/plugin/idea/psi/java/JavaSpanNavigationProvider.java

@@ -88,7 +88,7 @@ public void buildSpanNavigation() {
                 //for example is the IDE is closed when the cursor is on a method with Duration Breakdown that
                 // has span links, then start the IDE again, the insights view is populted already, without this refresh
                 // there will be no links.
-                project.getService(InsightsViewService.class).refreshInsights();
+                project.getService(InsightsViewService.class).refreshAllInsights();
                 project.getService(ErrorsViewService.class).refreshErrors();
 
             } finally {

src/main/kotlin/org/digma/intellij/plugin/ui/common/Panels.kt

@@ -118,7 +118,7 @@ private fun getGeneralRefreshButton(project: Project): JButton {
 
     generalRefreshIconButton.addMouseListener(object : MouseAdapter() {
         override fun mouseClicked(e: MouseEvent?) {
-            insightsActionListener.refreshInsights()
+            insightsActionListener.refreshAllInsights()
             errorsActionListener.refreshErrors()
         }
     })

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/InsightsCommon.kt

@@ -321,7 +321,7 @@ private fun getRefreshButton(insightPanel: DigmaResettablePanel, project: Projec
     val refreshAction = ActionLink(REFRESH)
     refreshAction.addActionListener {
         val actionListener: InsightsViewService = project.getService(InsightsViewService::class.java)
-        actionListener.refreshInsights()
+        actionListener.refreshAllInsights()
         rebuildInsightPanel(insightPanel)
     }
     refreshAction.border = empty()