Fix counter at the top of Summary tab (#193)

Author: MykolaYaremchuk

ide-common/src/main/kotlin/org/digma/intellij/plugin/ui/service/SummaryViewService.kt

@@ -9,6 +9,8 @@ import org.digma.intellij.plugin.common.DumbAwareNotifier
 import org.digma.intellij.plugin.log.Log
 import org.digma.intellij.plugin.model.Models
 import org.digma.intellij.plugin.model.rest.insights.GlobalInsight
+import org.digma.intellij.plugin.model.rest.insights.SpanDurationChangeInsight
+import org.digma.intellij.plugin.model.rest.insights.TopErrorFlowsInsight
 import org.digma.intellij.plugin.model.rest.usage.UsageStatusResult
 import org.digma.intellij.plugin.summary.SummariesProvider
 import org.digma.intellij.plugin.ui.model.PanelModel
@@ -78,7 +80,7 @@ class SummaryViewService(project: Project) : AbstractViewService(project) {
         val environmentStatuses = summariesProvider.environmentStatuses
         model.insights = insights
         model.usageStatusResult = UsageStatusResult(emptyList(), environmentStatuses)
-        model.count = insights.size
+        model.count = countElementsOnSummaryTab(insights)
         updateUi()
     }
 
@@ -112,6 +114,26 @@ class SummaryViewService(project: Project) : AbstractViewService(project) {
         override fun getUsageStatus(): UsageStatusResult = usageStatusResult
     }
 
-
+    private fun countElementsOnSummaryTab(insights: List<ListViewItem<*>>): Int {
+        var counter = 0
+        for (insight in insights) {
+            when (val model = insight.modelObject) {
+                is TopErrorFlowsInsight -> {
+                    for (error in model.errors) {
+                        counter ++
+                    }
+                }
+                is SpanDurationChangeInsight -> {
+                    for (change in model.spanDurationChanges) {
+                        val changedPercentiles = change.percentiles.filter { needToShowDurationChange(it) }
+                        if (changedPercentiles.isNotEmpty()) {
+                            counter ++
+                        }
+                    }
+                }
+            }
+        }
+        return counter
+    }
 }
 

ide-common/src/main/kotlin/org/digma/intellij/plugin/ui/service/ToolWindowTabsHelper.kt

@@ -3,6 +3,8 @@ package org.digma.intellij.plugin.ui.service
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.wm.ToolWindow
 import com.intellij.ui.content.Content
+import org.digma.intellij.plugin.model.rest.insights.SpanDurationsPercentile
+import kotlin.math.abs
 
 class ToolWindowTabsHelper(val project: Project) {
 
@@ -62,5 +64,14 @@ class ToolWindowTabsHelper(val project: Project) {
         toolWindow.contentManager.setSelectedContent(insightsContent)
     }
 
+}
 
+fun needToShowDurationChange(percentile: SpanDurationsPercentile): Boolean {
+    val tolerationConstant: Long = 10000
+
+    if (percentile.previousDuration != null && percentile.changeTime != null) {
+        val rawDiff: Long = abs(percentile.currentDuration.raw - percentile.previousDuration!!.raw)
+        return ((rawDiff.toFloat() / percentile.previousDuration!!.raw) > 0.1) && (rawDiff > tolerationConstant)
+    }
+    return false
 }

src/main/kotlin/org/digma/intellij/plugin/ui/list/PanelList.kt

@@ -97,7 +97,7 @@ abstract class PanelList(val project: Project, private var model: PanelListModel
         if (model.size <= 0)
             return
 
-        for (i in 0 until model.getSize()) run {
+        for (i in 0 until model.size) run {
             cellRenderer.apply {
                 val newComp: JPanel = getListCellRendererComponent(project, this@PanelList,
                         model.getElementAt(i), i, this@PanelList.hasFocus(), panelsLayoutHelper)

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/SpanPanels.kt

@@ -17,6 +17,7 @@ import org.digma.intellij.plugin.ui.common.spanGrayed
 import org.digma.intellij.plugin.ui.list.ListItemActionButton
 import org.digma.intellij.plugin.ui.list.PanelsLayoutHelper
 import org.digma.intellij.plugin.ui.model.TraceSample
+import org.digma.intellij.plugin.ui.service.needToShowDurationChange
 import org.ocpsoft.prettytime.PrettyTime
 import org.threeten.extra.AmountFormats
 import java.awt.BorderLayout
@@ -103,17 +104,6 @@ fun percentileRowPanel(percentile: SpanDurationsPercentile, panelsLayoutHelper:
     return durationsPanel
 }
 
-fun needToShowDurationChange(percentile: SpanDurationsPercentile): Boolean {
-    val tolerationConstant: Long = 10000
-
-    if (percentile.previousDuration != null && percentile.changeTime != null) {
-        val rawDiff: Long = abs(percentile.currentDuration.raw - percentile.previousDuration!!.raw)
-        return ((rawDiff.toFloat() / percentile.previousDuration!!.raw) > 0.1) && (rawDiff > tolerationConstant)
-    }
-
-    return false
-}
-
 // if cannot create the button then would return null
 fun buildButtonToJaeger(
     project: Project, linkCaption: String, spanName: String, traceSamples: List<TraceSample>

src/main/kotlin/org/digma/intellij/plugin/ui/list/summaries/SummaryPanelList.kt

@@ -8,8 +8,8 @@ import org.digma.intellij.plugin.model.rest.insights.SpanDurationChangeInsight
 import org.digma.intellij.plugin.model.rest.insights.TopErrorFlowsInsight
 import org.digma.intellij.plugin.ui.list.AbstractPanelListModel
 import org.digma.intellij.plugin.ui.list.PanelList
-import org.digma.intellij.plugin.ui.list.insights.needToShowDurationChange
 import org.digma.intellij.plugin.ui.model.listview.ListViewItem
+import org.digma.intellij.plugin.ui.service.needToShowDurationChange
 import java.util.Collections
 
 class SummaryPanelList(project: Project, listViewItems: List<ListViewItem<*>>) : PanelList(project, Model(listViewItems)) {

src/main/kotlin/org/digma/intellij/plugin/ui/list/summaries/SummaryPanelListCellRenderer.kt

@@ -87,8 +87,7 @@ private fun buildError(model: TopErrorFlowsInsight.Error, project: Project): JPa
 }
 
 private fun getCharacteristic(model: TopErrorFlowsInsight.Error): JPanel {
-    val maxScore = model.scoreMovingAvg.coerceAtLeast(model.scoreRecency).coerceAtLeast(model.scoreTrendSlope)
-    val text = when (maxScore) {
+    val text = when (model.scoreMovingAvg.coerceAtLeast(model.scoreRecency).coerceAtLeast(model.scoreTrendSlope)) {
         model.scoreRecency -> "Recent"
         model.scoreMovingAvg -> "Frequent"
         model.scoreTrendSlope -> "Escalating"