refactor: clean up PLC0415 noqa violations in experiments, evaluations, human_annotations#3030
Open
claude[bot] wants to merge 1 commit intomainfrom
Open
refactor: clean up PLC0415 noqa violations in experiments, evaluations, human_annotations#3030claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
…s, human_annotations - Move convenience imports to module level (Team, CustomTaggedItem, urlencode, translate_messages_with_llm, LlmProvider, django.conf.settings, QueryDict, FilterParams, compute_aggregates_for_run, json, EvaluationRunAggregate, evaluators, resolve_references) - Remove duplicate inline imports in test files (AnnotationItem, ExperimentSessionFactory, ChatMessageFactory, AnnotationSessionsSelectionTable) - Add noqa: PLC0415 - circular: <description> comments on all retained circular imports - Add noqa: PLC0415 - lazy: <reason> on langchain import kept for startup performance Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Description
Cleans up
# noqa: PLC0415suppression comments inapps/experiments/,apps/evaluations/, andapps/human_annotations/as part of issue #2994.For each violation:
Changes:
experiments/models.py,experiments/views/experiment.py,experiments/management/commands/fix_vector_store_duplication.py,evaluations/evaluators.py,evaluations/tasks.py,evaluations/views/,evaluations/tables.py,evaluations/tests/,human_annotations/tests/test_views.pyexperiments/models.py(14 circular),experiments/tasks.py(langchain startup),evaluations/models.py,evaluations/utils.py,human_annotations/models.pyNote: Task 2 (utils + pipelines) was already completed by a previous PR (#3024) — all remaining noqa annotations there are properly documented circular/lazy imports.
Migrations
Demo
N/A - refactoring only
Docs and Changelog