add a databrick database connection#99
Open
yukinko-iwasaki wants to merge 15 commits intointernal-distribution-mainfrom
Open
add a databrick database connection#99yukinko-iwasaki wants to merge 15 commits intointernal-distribution-mainfrom
yukinko-iwasaki wants to merge 15 commits intointernal-distribution-mainfrom
Conversation
adding connection logic Update server.R minor fixes use the sql-warehouse instead
weilu
reviewed
Oct 15, 2025
Comment on lines
+12
to
+18
| source("server_scripts/duplicates.R", local = TRUE) | ||
| source("server_scripts/outliers.R", local = TRUE) | ||
| source("server_scripts/enumerator.R", local = TRUE) | ||
| source("server_scripts/admin.R", local = TRUE) | ||
| source("server_scripts/unit.R", local = TRUE) | ||
| source("server_scripts/summary.R", local = TRUE) | ||
| source("server_scripts/connection.R", local = TRUE) |
There was a problem hiding this comment.
@yukinko-iwasaki did you test that this change works with windows? The original implementation might be more platform agnostic
Comment on lines
-2142
to
-2144
| tags$div(style = "text-align: center;", | ||
| shinycssloaders::withSpinner(tags$p("Please wait, your report is being generated...")) | ||
| ), |
Comment on lines
+19
to
+20
| cursor.close() | ||
| conn.close() |
There was a problem hiding this comment.
Is there a way to ensure the closure of these, regardless of possible fetch exceptions?
Comment on lines
+2
to
+4
| databricks-sdk>=0.65.0 | ||
| databricks-sql-connector>=4.1.3 | ||
| databricks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add databricks connection feature.