Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds currency information to the country table by joining with an exchange rate reference table. The changes enable the country table to include currency name and currency code fields for each country.
Changes:
- Modified admin1 boundaries to include ISO2 country codes
- Added currency data from the corporate reference data catalog
- Joined currency information with country data using ISO2 country codes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| geo/admin_boundaries_dlt.py | Added country_code_iso2 field to admin1_boundaries_gold table |
| country.py | Added currency data join using ISO2 country codes and integrated currency fields into country table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
weilu
requested changes
Feb 25, 2026
|
|
||
| # COMMAND ---------- | ||
|
|
||
| from pyspark.sql import Window |
Comment on lines
+105
to
+107
| CATALOG = "prd_corpdata" | ||
| SCHEMA = "dm_reference_gold" # v_dim_country would be more suitable for currency/country data, but it currently lacks comprehensive data. May switch to this table in the future. | ||
| TABLE = "v_dim_country_currency_exchange_rate" |
Contributor
There was a problem hiding this comment.
No need to define these constants as they are only used in the construction of base_df. Also, as a best practice, please avoid redefining constants – these constant names are used again on line 133-135.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.