Restore --connect for remote sessions - #16
Closed
jeff-hykin wants to merge 8 commits into
Closed
Conversation
…PC proxy When --connect is provided (with optional URL), the viewer connects to an existing gRPC proxy server instead of spawning its own. This mirrors the stock rerun binary's --connect behavior. Defaults to rerun+http://127.0.0.1:<port>/proxy.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
- Remove unused `parking_lot` dependency (cargo-shear) - Add `[lints] workspace = true` to dimos/Cargo.toml (rerun lint) - Fix TOML formatting in dimos/pyproject.toml (taplo) - Rename error variables from `e` to `err` (rerun lint convention) - Fix trailing whitespace in keyboard.rs - Add blank lines before doc comments on struct fields/constants - Use Display instead of Debug for error formatting in viewer.rs - Commit updated Cargo.lock Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
THis PR only passes through --connect. Need ALL rerun args so we dont have to do this 10 more times in future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restore --connect so we can connect to remote sessions