fix clippy complaints

Author: ThierryBerger

Cargo.toml

@@ -23,7 +23,14 @@ path = "src/lib.rs"
 
 [features]
 default = ["std", "macros"]
-std = ["matrixmultiply", "num-traits/std", "num-complex/std", "num-rational/std", "approx/std", "simba/std"]
+std = [
+    "matrixmultiply",
+    "num-traits/std",
+    "num-complex/std",
+    "num-rational/std",
+    "approx/std",
+    "simba/std",
+]
 sparse = []
 debug = ["approx/num-complex", "rand"]
 alloc = []
@@ -67,7 +74,13 @@ rkyv-serialize = ["rkyv-serialize-no-std", "rkyv/std", "rkyv/validation"]
 ## To use rand in a #[no-std] environment, enable the
 ## `rand-no-std` feature instead of `rand`.
 rand-no-std = ["rand-package"]
-rand = ["rand-no-std", "rand-package/std", "rand-package/std_rng", "rand-package/thread_rng", "rand_distr"]
+rand = [
+    "rand-no-std",
+    "rand-package/std",
+    "rand-package/std_rng",
+    "rand-package/thread_rng",
+    "rand_distr",
+]
 
 # Tests
 arbitrary = ["quickcheck"]
@@ -87,15 +100,19 @@ simba = { version = "0.9", default-features = false }
 alga = { version = "0.9", default-features = false, optional = true }
 rand_distr = { version = "0.5", default-features = false, optional = true }
 matrixmultiply = { version = "0.3", optional = true }
-serde = { version = "1.0", default-features = false, features = ["derive"], optional = true }
+serde = { version = "1.0", default-features = false, features = [
+    "derive",
+], optional = true }
 rkyv = { version = "0.7.41", default-features = false, optional = true }
 mint = { version = "0.5", optional = true }
 quickcheck = { version = "1", optional = true }
 pest = { version = "2", optional = true }
 pest_derive = { version = "2", optional = true }
 bytemuck = { version = "1.5", optional = true }
 matrixcompare-core = { version = "0.1", optional = true }
-proptest = { version = "1", optional = true, default-features = false, features = ["std"] }
+proptest = { version = "1", optional = true, default-features = false, features = [
+    "std",
+] }
 glam014 = { package = "glam", version = "0.14", optional = true }
 glam015 = { package = "glam", version = "0.15", optional = true }
 glam016 = { package = "glam", version = "0.16", optional = true }
@@ -131,7 +148,12 @@ trybuild = "1.0.90"
 cool_asserts = "2.0.3"
 
 [workspace]
-members = ["nalgebra-lapack", "nalgebra-glm", "nalgebra-sparse", "nalgebra-macros"]
+members = [
+    "nalgebra-lapack",
+    "nalgebra-glm",
+    "nalgebra-sparse",
+    "nalgebra-macros",
+]
 resolver = "2"
 
 [[example]]

nalgebra-sparse/src/factorization/cholesky.rs

@@ -308,7 +308,7 @@ fn reach(
 
     for &irow in pattern.lane(j) {
         let mut curr = irow;
-        while curr != usize::max_value() && curr <= max_j && !marks[curr] {
+        while curr != usize::MAX && curr <= max_j && !marks[curr] {
             marks[curr] = true;
             tmp.push(curr);
             curr = tree[curr];
@@ -352,8 +352,8 @@ fn elimination_tree(pattern: &SparsityPattern) -> Vec<usize> {
     // Note: The pattern is assumed to of a CSC matrix, so the number of rows is
     // given by the minor dimension
     let nrows = pattern.minor_dim();
-    let mut forest: Vec<_> = iter::repeat(usize::max_value()).take(nrows).collect();
-    let mut ancestor: Vec<_> = iter::repeat(usize::max_value()).take(nrows).collect();
+    let mut forest: Vec<_> = iter::repeat(usize::MAX).take(nrows).collect();
+    let mut ancestor: Vec<_> = iter::repeat(usize::MAX).take(nrows).collect();
 
     for k in 0..nrows {
         for &irow in pattern.lane(k) {
@@ -363,7 +363,7 @@ fn elimination_tree(pattern: &SparsityPattern) -> Vec<usize> {
                 let i_ancestor = ancestor[i];
                 ancestor[i] = k;
 
-                if i_ancestor == usize::max_value() {
+                if i_ancestor == usize::MAX {
                     forest[i] = k;
                     break;
                 }

src/base/dimension.rs

@@ -53,7 +53,7 @@ impl<'de> Deserialize<'de> for Dyn {
     where
         D: Deserializer<'de>,
     {
-        usize::deserialize(deserializer).map(|x| Dyn(x))
+        usize::deserialize(deserializer).map(Dyn)
     }
 }
 

src/base/iter.rs

@@ -1,9 +1,5 @@
 //! Matrix iterators.
 
-// only enables the `doc_cfg` feature when
-// the `docsrs` configuration attribute is defined
-#![cfg_attr(docsrs, feature(doc_cfg))]
-
 use core::fmt::Debug;
 use core::ops::Range;
 use std::iter::FusedIterator;

src/base/matrix_view.rs

@@ -131,13 +131,13 @@ view_storage_impl!("A mutable matrix data storage for mutable matrix view. Only
     RawStorageMut as &'a mut S; SliceStorageMut => ViewStorageMut.get_address_unchecked_mut(*mut T as &'a mut T)
 );
 
-impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Copy
-    for ViewStorage<'a, T, R, C, RStride, CStride>
+impl<T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Copy
+    for ViewStorage<'_, T, R, C, RStride, CStride>
 {
 }
 
-impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Clone
-    for ViewStorage<'a, T, R, C, RStride, CStride>
+impl<T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Clone
+    for ViewStorage<'_, T, R, C, RStride, CStride>
 {
     #[inline]
     fn clone(&self) -> Self {
@@ -240,8 +240,8 @@ macro_rules! storage_impl(
 
 storage_impl!(ViewStorage, ViewStorageMut);
 
-unsafe impl<'a, T, R: Dim, C: Dim, RStride: Dim, CStride: Dim> RawStorageMut<T, R, C>
-    for ViewStorageMut<'a, T, R, C, RStride, CStride>
+unsafe impl<T, R: Dim, C: Dim, RStride: Dim, CStride: Dim> RawStorageMut<T, R, C>
+    for ViewStorageMut<'_, T, R, C, RStride, CStride>
 {
     #[inline]
     fn ptr_mut(&mut self) -> *mut T {
@@ -260,18 +260,15 @@ unsafe impl<'a, T, R: Dim, C: Dim, RStride: Dim, CStride: Dim> RawStorageMut<T,
     }
 }
 
-unsafe impl<'a, T, R: Dim, CStride: Dim> IsContiguous for ViewStorage<'a, T, R, U1, U1, CStride> {}
-unsafe impl<'a, T, R: Dim, CStride: Dim> IsContiguous
-    for ViewStorageMut<'a, T, R, U1, U1, CStride>
-{
-}
+unsafe impl<T, R: Dim, CStride: Dim> IsContiguous for ViewStorage<'_, T, R, U1, U1, CStride> {}
+unsafe impl<T, R: Dim, CStride: Dim> IsContiguous for ViewStorageMut<'_, T, R, U1, U1, CStride> {}
 
-unsafe impl<'a, T, R: DimName, C: Dim + IsNotStaticOne> IsContiguous
-    for ViewStorage<'a, T, R, C, U1, R>
+unsafe impl<T, R: DimName, C: Dim + IsNotStaticOne> IsContiguous
+    for ViewStorage<'_, T, R, C, U1, R>
 {
 }
-unsafe impl<'a, T, R: DimName, C: Dim + IsNotStaticOne> IsContiguous
-    for ViewStorageMut<'a, T, R, C, U1, R>
+unsafe impl<T, R: DimName, C: Dim + IsNotStaticOne> IsContiguous
+    for ViewStorageMut<'_, T, R, C, U1, R>
 {
 }
 

src/base/ops.rs

@@ -95,7 +95,7 @@ where
     }
 }
 
-impl<'a, T, R: Dim, C: Dim, S> Neg for &'a Matrix<T, R, C, S>
+impl<T, R: Dim, C: Dim, S> Neg for &Matrix<T, R, C, S>
 where
     T: Scalar + ClosedNeg,
     S: Storage<T, R, C>,
@@ -550,8 +550,8 @@ macro_rules! left_scalar_mul_impl(
 left_scalar_mul_impl!(u8, u16, u32, u64, usize, i8, i16, i32, i64, isize, f32, f64);
 
 // Matrix × Matrix
-impl<'a, 'b, T, R1: Dim, C1: Dim, R2: Dim, C2: Dim, SA, SB> Mul<&'b Matrix<T, R2, C2, SB>>
-    for &'a Matrix<T, R1, C1, SA>
+impl<'b, T, R1: Dim, C1: Dim, R2: Dim, C2: Dim, SA, SB> Mul<&'b Matrix<T, R2, C2, SB>>
+    for &Matrix<T, R1, C1, SA>
 where
     T: Scalar + Zero + One + ClosedAddAssign + ClosedMulAssign,
     SA: Storage<T, R1, C1>,
@@ -572,8 +572,8 @@ where
     }
 }
 
-impl<'a, T, R1: Dim, C1: Dim, R2: Dim, C2: Dim, SA, SB> Mul<Matrix<T, R2, C2, SB>>
-    for &'a Matrix<T, R1, C1, SA>
+impl<T, R1: Dim, C1: Dim, R2: Dim, C2: Dim, SA, SB> Mul<Matrix<T, R2, C2, SB>>
+    for &Matrix<T, R1, C1, SA>
 where
     T: Scalar + Zero + One + ClosedAddAssign + ClosedMulAssign,
     SB: Storage<T, R2, C2>,

src/base/par_iter.rs

@@ -1,9 +1,5 @@
 //! Parallel iterators for matrices compatible with rayon.
 
-// only enables the `doc_cfg` feature when
-// the `docsrs` configuration attribute is defined
-#![cfg_attr(docsrs, feature(doc_cfg))]
-
 use crate::{
     iter::{ColumnIter, ColumnIterMut},
     Dim, Matrix, MatrixView, MatrixViewMut, RawStorage, RawStorageMut, Scalar, U1,
@@ -15,9 +11,10 @@ use rayon::{iter::plumbing::bridge, prelude::*};
 /// using the [`par_column_iter`] method of [`Matrix`].
 ///
 /// *Only available if compiled with the feature `rayon`.*
+///
 /// [`par_column_iter`]: crate::Matrix::par_column_iter
 /// [`Matrix`]: crate::Matrix
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 pub struct ParColumnIter<'a, T, R: Dim, Cols: Dim, S: RawStorage<T, R, Cols>> {
     mat: &'a Matrix<T, R, Cols, S>,
 }
@@ -29,7 +26,7 @@ impl<'a, T, R: Dim, Cols: Dim, S: RawStorage<T, R, Cols>> ParColumnIter<'a, T, R
     }
 }
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 impl<'a, T, R: Dim, Cols: Dim, S: RawStorage<T, R, Cols>> ParallelIterator
     for ParColumnIter<'a, T, R, Cols, S>
 where
@@ -50,10 +47,10 @@ where
     }
 }
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 /// *Only available if compiled with the feature `rayon`.*
-impl<'a, T, R: Dim, Cols: Dim, S: RawStorage<T, R, Cols>> IndexedParallelIterator
-    for ParColumnIter<'a, T, R, Cols, S>
+impl<T, R: Dim, Cols: Dim, S: RawStorage<T, R, Cols>> IndexedParallelIterator
+    for ParColumnIter<'_, T, R, Cols, S>
 where
     T: Send + Sync + Scalar,
     S: Sync,
@@ -75,7 +72,7 @@ where
     }
 }
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 /// A rayon parallel iterator through the mutable columns of a matrix.
 /// *Only available if compiled with the feature `rayon`.*
 pub struct ParColumnIterMut<
@@ -88,7 +85,7 @@ pub struct ParColumnIterMut<
     mat: &'a mut Matrix<T, R, Cols, S>,
 }
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 /// *only available if compiled with the feature `rayon`*
 impl<'a, T, R, Cols, S> ParColumnIterMut<'a, T, R, Cols, S>
 where
@@ -102,7 +99,7 @@ where
     }
 }
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 /// *Only available if compiled with the feature `rayon`*
 impl<'a, T, R, Cols, S> ParallelIterator for ParColumnIterMut<'a, T, R, Cols, S>
 where
@@ -125,9 +122,9 @@ where
     }
 }
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 /// *Only available if compiled with the feature `rayon`*
-impl<'a, T, R, Cols, S> IndexedParallelIterator for ParColumnIterMut<'a, T, R, Cols, S>
+impl<T, R, Cols, S> IndexedParallelIterator for ParColumnIterMut<'_, T, R, Cols, S>
 where
     R: Dim,
     Cols: Dim,
@@ -152,7 +149,7 @@ where
     }
 }
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 /// # Parallel iterators using `rayon`
 /// *Only available if compiled with the feature `rayon`*
 impl<T, R: Dim, Cols: Dim, S: RawStorage<T, R, Cols>> Matrix<T, R, Cols, S>
@@ -225,7 +222,7 @@ where
 /// rayon trait part of the public interface of the `ColumnIter`.
 struct ColumnProducer<'a, T, R: Dim, C: Dim, S: RawStorage<T, R, C>>(ColumnIter<'a, T, R, C, S>);
 
-#[cfg_attr(doc_cfg, doc(cfg(feature = "rayon")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "rayon")))]
 /// *only available if compiled with the feature `rayon`*
 impl<'a, T, R: Dim, Cols: Dim, S: RawStorage<T, R, Cols>> Producer
     for ColumnProducer<'a, T, R, Cols, S>

src/base/rkyv_wrappers.rs

@@ -1,4 +1,4 @@
-//! Wrapper that allows changing the generic type of a PhantomData<T>
+//! Wrapper that allows changing the generic type of a `PhantomData<NT>`
 //!
 //! Copied from <https://github.com/rkyv/rkyv_contrib> (MIT-Apache2 licences) which isn’t published yet.
 
@@ -8,7 +8,7 @@ use rkyv::{
 };
 use std::marker::PhantomData;
 
-/// A wrapper that allows for changing the generic type of a `PhantomData<T>`.
+/// A wrapper that allows for changing the generic type of a `PhantomData<NT>`.
 pub struct CustomPhantom<NT: ?Sized> {
     _data: PhantomData<*const NT>,
 }

src/debug/random_sdp.rs

@@ -32,7 +32,7 @@ where
     /// Creates a new well conditioned symmetric definite-positive matrix from its dimension and a
     /// random reals generators.
     pub fn new<Rand: FnMut() -> T>(dim: D, mut rand: Rand) -> Self {
-        let mut m = RandomOrthogonal::new(dim, || rand()).unwrap();
+        let mut m = RandomOrthogonal::new(dim, &mut rand).unwrap();
         let mt = m.adjoint();
 
         for i in 0..dim.value() {

src/geometry/dual_quaternion_ops.rs

@@ -98,7 +98,7 @@ where
     }
 }
 
-impl<'a, T: SimdRealField> Neg for &'a DualQuaternion<T>
+impl<T: SimdRealField> Neg for &DualQuaternion<T>
 where
     T::Element: SimdRealField,
 {
@@ -122,7 +122,7 @@ where
     }
 }
 
-impl<'a, T: SimdRealField> Neg for &'a UnitDualQuaternion<T>
+impl<T: SimdRealField> Neg for &UnitDualQuaternion<T>
 where
     T::Element: SimdRealField,
 {