wip migrating to rkyv 0.8 ; one compiling error type left

Author: ThierryBerger

Cargo.toml

@@ -23,7 +23,14 @@ path = "src/lib.rs"
 
 [features]
 default = ["std", "macros"]
-std = ["matrixmultiply", "num-traits/std", "num-complex/std", "num-rational/std", "approx/std", "simba/std"]
+std = [
+    "matrixmultiply",
+    "num-traits/std",
+    "num-complex/std",
+    "num-rational/std",
+    "approx/std",
+    "simba/std",
+]
 sparse = []
 debug = ["approx/num-complex", "rand"]
 alloc = []
@@ -59,20 +66,26 @@ convert-glam029 = ["glam029"]
 ## `serde-serialize`.
 serde-serialize-no-std = ["serde", "num-complex/serde"]
 serde-serialize = ["serde-serialize-no-std", "serde/std"]
-rkyv-serialize-no-std = ["rkyv/size_32"]
-rkyv-serialize = ["rkyv-serialize-no-std", "rkyv/std", "rkyv/validation"]
+rkyv-serialize-no-std = ["rkyv/pointer_width_32"]
+rkyv-serialize = ["rkyv-serialize-no-std", "rkyv/std", "rkyv/bytecheck"]
 
 # Randomness
 ## To use rand in a #[no-std] environment, enable the
 ## `rand-no-std` feature instead of `rand`.
 rand-no-std = ["rand-package"]
-rand = ["rand-no-std", "rand-package/std", "rand-package/std_rng", "rand-package/thread_rng", "rand_distr"]
+rand = [
+    "rand-no-std",
+    "rand-package/std",
+    "rand-package/std_rng",
+    "rand-package/thread_rng",
+    "rand_distr",
+]
 
 # Tests
 arbitrary = ["quickcheck"]
 proptest-support = ["proptest"]
 slow-tests = []
-rkyv-safe-deser = ["rkyv-serialize", "rkyv/validation"]
+rkyv-safe-deser = ["rkyv-serialize", "rkyv/bytecheck"]
 
 [dependencies]
 nalgebra-macros = { version = "0.2.2", path = "nalgebra-macros", optional = true }
@@ -86,15 +99,19 @@ simba = { version = "0.9", default-features = false }
 alga = { version = "0.9", default-features = false, optional = true }
 rand_distr = { version = "0.5", default-features = false, optional = true }
 matrixmultiply = { version = "0.3", optional = true }
-serde = { version = "1.0", default-features = false, features = ["derive"], optional = true }
-rkyv = { version = "0.7.41", default-features = false, optional = true }
+serde = { version = "1.0", default-features = false, features = [
+    "derive",
+], optional = true }
+rkyv = { version = "0.8", default-features = false, optional = true }
 mint = { version = "0.5", optional = true }
 quickcheck = { version = "1", optional = true }
 pest = { version = "2", optional = true }
 pest_derive = { version = "2", optional = true }
 bytemuck = { version = "1.5", optional = true }
 matrixcompare-core = { version = "0.1", optional = true }
-proptest = { version = "1", optional = true, default-features = false, features = ["std"] }
+proptest = { version = "1", optional = true, default-features = false, features = [
+    "std",
+] }
 glam014 = { package = "glam", version = "0.14", optional = true }
 glam015 = { package = "glam", version = "0.15", optional = true }
 glam016 = { package = "glam", version = "0.16", optional = true }
@@ -129,7 +146,12 @@ trybuild = "1.0.90"
 cool_asserts = "2.0.3"
 
 [workspace]
-members = ["nalgebra-lapack", "nalgebra-glm", "nalgebra-sparse", "nalgebra-macros"]
+members = [
+    "nalgebra-lapack",
+    "nalgebra-glm",
+    "nalgebra-sparse",
+    "nalgebra-macros",
+]
 resolver = "2"
 
 [[example]]

src/base/array_storage.rs

@@ -11,9 +11,6 @@ use serde::{Deserialize, Deserializer, Serialize, Serializer};
 #[cfg(feature = "serde-serialize-no-std")]
 use std::marker::PhantomData;
 
-#[cfg(feature = "rkyv-serialize")]
-use rkyv::bytecheck;
-
 use crate::base::allocator::Allocator;
 use crate::base::default_allocator::DefaultAllocator;
 use crate::base::dimension::{Const, ToTypenum};
@@ -33,15 +30,14 @@ use std::mem;
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(
-        as = "ArrayStorage<T::Archived, R, C>",
-        bound(archive = "
-        T: rkyv::Archive,
-        [[T; R]; C]: rkyv::Archive<Archived = [[T::Archived; R]; C]>
-    ")
+    rkyv(
+        as = ArrayStorage<T::Archived, R, C>,
+        archive_bounds(
+            T: rkyv::Archive,
+            [[T; R]; C]: rkyv::Archive<Archived = [[T::Archived; R]; C]>
+        )
     )
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 pub struct ArrayStorage<T, const R: usize, const C: usize>(pub [[T; R]; C]);
 
 impl<T, const R: usize, const C: usize> ArrayStorage<T, R, C> {

src/base/dimension.rs

@@ -8,8 +8,6 @@ use std::fmt::Debug;
 use std::ops::{Add, Div, Mul, Sub};
 use typenum::{self, Diff, Max, Maximum, Min, Minimum, Prod, Quot, Sum, Unsigned};
 
-#[cfg(feature = "rkyv-serialize")]
-use rkyv::bytecheck;
 #[cfg(feature = "serde-serialize-no-std")]
 use serde::{Deserialize, Deserializer, Serialize, Serializer};
 
@@ -19,10 +17,6 @@ use serde::{Deserialize, Deserializer, Serialize, Serializer};
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
-#[cfg_attr(
-    feature = "rkyv-serialize",
-    archive_attr(derive(bytecheck::CheckBytes))
-)]
 pub struct Dyn(pub usize);
 
 #[deprecated(note = "use Dyn instead.")]
@@ -216,9 +210,8 @@ dim_ops!(
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(as = "Self")
+    rkyv(derive(Debug), compare(PartialEq))
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 pub struct Const<const R: usize>;
 
 /// Trait implemented exclusively by type-level integers.

src/base/matrix.rs

@@ -13,8 +13,6 @@ use serde::{Deserialize, Deserializer, Serialize, Serializer};
 
 #[cfg(feature = "rkyv-serialize-no-std")]
 use super::rkyv_wrappers::CustomPhantom;
-#[cfg(feature = "rkyv-serialize")]
-use rkyv::bytecheck;
 #[cfg(feature = "rkyv-serialize-no-std")]
 use rkyv::{with::With, Archive, Archived};
 
@@ -161,16 +159,14 @@ pub type MatrixCross<T, R1, C1, R2, C2> =
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(
-        as = "Matrix<T::Archived, R, C, S::Archived>",
-        bound(archive = "
-        T: Archive,
-        S: Archive,
-        With<PhantomData<(T, R, C)>, CustomPhantom<(Archived<T>, R, C)>>: Archive<Archived = PhantomData<(Archived<T>, R, C)>>
-    ")
+    rkyv(as = Matrix<T::Archived, R, C, S::Archived>,
+        archive_bounds(
+            T: Archive,
+            S: Archive,
+            With<PhantomData<(T, R, C)>, CustomPhantom<(Archived<T>, R, C)>>: Archive<Archived = PhantomData<(Archived<T>, R, C)>>
+        )
     )
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 pub struct Matrix<T, R, C, S> {
     /// The data storage that contains all the matrix components. Disappointed?
     ///
@@ -207,7 +203,7 @@ pub struct Matrix<T, R, C, S> {
     //       of the `RawStorage` trait. However, because we don't have
     //       specialization, this is not possible because these `T, R, C`
     //       allows us to desambiguate a lot of configurations.
-    #[cfg_attr(feature = "rkyv-serialize-no-std", with(CustomPhantom<(T::Archived, R, C)>))]
+    #[cfg_attr(feature = "rkyv-serialize-no-std", rkyv(with = CustomPhantom<(T::Archived, R, C)>))]
     _phantoms: PhantomData<(T, R, C)>,
 }
 

src/base/rkyv_wrappers.rs

@@ -3,8 +3,9 @@
 //! Copied from <https://github.com/rkyv/rkyv_contrib> (MIT-Apache2 licences) which isn’t published yet.
 
 use rkyv::{
+    rancor::Fallible,
     with::{ArchiveWith, DeserializeWith, SerializeWith},
-    Fallible,
+    Place,
 };
 use std::marker::PhantomData;
 
@@ -18,13 +19,7 @@ impl<OT: ?Sized, NT: ?Sized> ArchiveWith<PhantomData<OT>> for CustomPhantom<NT>
     type Resolver = ();
 
     #[inline]
-    unsafe fn resolve_with(
-        _: &PhantomData<OT>,
-        _: usize,
-        _: Self::Resolver,
-        _: *mut Self::Archived,
-    ) {
-    }
+    fn resolve_with(_: &PhantomData<OT>, _: Self::Resolver, _: Place<Self::Archived>) {}
 }
 
 impl<OT: ?Sized, NT: ?Sized, S: Fallible + ?Sized> SerializeWith<PhantomData<OT>, S>

src/base/unit.rs

@@ -9,9 +9,6 @@ use crate::base::DefaultAllocator;
 use crate::storage::RawStorage;
 use crate::{Dim, Matrix, OMatrix, RealField, Scalar, SimdComplexField, SimdRealField};
 
-#[cfg(feature = "rkyv-serialize")]
-use rkyv::bytecheck;
-
 /// A wrapper that ensures the underlying algebraic entity has a unit norm.
 ///
 /// **It is likely that the only piece of documentation that you need in this page are:**
@@ -27,14 +24,12 @@ use rkyv::bytecheck;
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(
-        as = "Unit<T::Archived>",
-        bound(archive = "
-        T: rkyv::Archive,
-    ")
+    rkyv(as = Unit<T::Archived>,
+        archive_bounds(
+            T: rkyv::Archive,
+        )
     )
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 pub struct Unit<T> {
     pub(crate) value: T,
 }

src/geometry/dual_quaternion.rs

@@ -46,15 +46,13 @@ use simba::scalar::{ClosedNeg, RealField};
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(
-        as = "DualQuaternion<T::Archived>",
-        bound(archive = "
-        T: rkyv::Archive,
-        Quaternion<T>: rkyv::Archive<Archived = Quaternion<T::Archived>>
-    ")
+    rkyv(as = DualQuaternion<T::Archived>,
+        archive_bounds(
+            T: rkyv::Archive,
+            Quaternion<T>: rkyv::Archive<Archived = Quaternion<T::Archived>>
+        )
     )
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 pub struct DualQuaternion<T> {
     /// The real component of the quaternion
     pub real: Quaternion<T>,

src/geometry/isometry.rs

@@ -71,17 +71,15 @@ use rkyv::bytecheck;
                        Owned<T, Const<D>>: Deserialize<'de>,
                        T: Scalar"))
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(
-        as = "Isometry<T::Archived, R::Archived, D>",
-        bound(archive = "
-        T: rkyv::Archive,
-        R: rkyv::Archive,
-        Translation<T, D>: rkyv::Archive<Archived = Translation<T::Archived, D>>
-    ")
+    rkyv(as = Isometry<T::Archived, R::Archived, D>,
+        archive_bounds(
+            T: rkyv::Archive,
+            R: rkyv::Archive,
+            Translation<T, D>: rkyv::Archive<Archived = Translation<T::Archived, D>>
+        )
     )
 )]
 pub struct Isometry<T, R, const D: usize> {

src/geometry/orthographic.rs

@@ -25,15 +25,13 @@ use rkyv::bytecheck;
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(
-        as = "Orthographic3<T::Archived>",
-        bound(archive = "
-        T: rkyv::Archive,
-        Matrix4<T>: rkyv::Archive<Archived = Matrix4<T::Archived>>
-    ")
+    rkyv(as = Orthographic3<T::Archived>,
+        archive_bounds(
+            T: rkyv::Archive,
+            Matrix4<T>: rkyv::Archive<Archived = Matrix4<T::Archived>>
+        )
     )
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[derive(Copy, Clone)]
 pub struct Orthographic3<T> {
     matrix: Matrix4<T>,

src/geometry/perspective.rs

@@ -19,22 +19,20 @@ use crate::base::{Matrix4, Vector, Vector3};
 use crate::geometry::{Point3, Projective3};
 
 #[cfg(feature = "rkyv-serialize")]
-use rkyv::bytecheck;
+use rkyv::{bytecheck, rancor};
 
 /// A 3D perspective projection stored as a homogeneous 4x4 matrix.
 #[repr(C)]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize),
-    archive(
-        as = "Perspective3<T::Archived>",
-        bound(archive = "
-        T: rkyv::Archive,
-        Matrix4<T>: rkyv::Archive<Archived = Matrix4<T::Archived>>
-    ")
+    rkyv(as = Perspective3<T::Archived>,
+        archive_bounds(
+            T: rkyv::Archive,
+            Matrix4<T>: rkyv::Archive<Archived = Matrix4<T::Archived>>
+        )
     )
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[derive(Copy, Clone)]
 pub struct Perspective3<T> {
     matrix: Matrix4<T>,