Merged
Conversation
3805503 to
00e08b1
Compare
Also suppress output for passing tests.
rename ert tests file test.el => el-get-tests.el move el-get-issue-* files to separate dir
Fix compile warnings that snuck in while the test was broken.
npostavs
added a commit
that referenced
this pull request
Nov 15, 2015
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, I'm finding #2264 really needs some tests with it, so it's time to actually get a bit more serious about the ert tests.
Extends/replaces/ closes #969. We'll need to take another look at the failure, but for now I marked it as
:expected-failure.Close #739, it's basically too boring to go over all of the existing issue replicators so I can't see it ever getting done; I'm just moving them to a subdirectory.
Sort of fixes #1691.