Skip to content

Conversation

ilstefano
Copy link

Hi @dineshsalunke,
here is Stephan, and I'm interested in adding projects related improvements into Forgejo.
Starting with the projects-API I found your Gitea PR and tried to get the integration tests running.
So first of all, thanks a lot for your work! I hope it's ok for you that I took it and tried to get it running.
So secondly I would like to disclaim that I'm not sure whether I'm on the same page as you, but I think I needed to add and adjust some code so that all use cases work now, especially with respect to the endpoints and the DTOs.
Perhaps you could check whether I went in the right direction?
What I would like to do next is implementing an authorization layer, so that the permissions to read and write projects are the same as in the web UI.
When everything is fine you could contribute to Gitea, and I would offer to contribute the code to the Forgejo community.
So far, I'm looking forward to get your thoughts!
Stephan

@ilstefano
Copy link
Author

FYI, how I run the tests:

make generate-ini-sqlite

go test -v -tags="sqlite sqlite_unlock_notify" ./tests/integration/ -run "TestAPI.*Project[s]?" | grep -a -E "PASS|FAIL|RUN"
=== RUN   TestAPICreateUserProject
--- PASS: TestAPICreateUserProject (0.46s)
=== RUN   TestAPICreateOrgProject
--- PASS: TestAPICreateOrgProject (0.34s)
=== RUN   TestAPICreateRepoProject
--- PASS: TestAPICreateRepoProject (0.27s)
=== RUN   TestAPIListUserProjects
--- PASS: TestAPIListUserProjects (0.27s)
=== RUN   TestAPIListOrgProjects
--- PASS: TestAPIListOrgProjects (0.27s)
=== RUN   TestAPIListRepoProjects
--- PASS: TestAPIListRepoProjects (0.28s)
=== RUN   TestAPIGetProject
--- PASS: TestAPIGetProject (0.27s)
=== RUN   TestAPIUpdateProject
--- PASS: TestAPIUpdateProject (0.26s)
=== RUN   TestAPIDeleteProject
--- PASS: TestAPIDeleteProject (0.26s)
PASS

@dineshsalunke
Copy link
Owner

@ilstefano sure I will go through the changes. also the reason the PR keeps being stagnant at some point, is due to the permissions implementation.

It would be great if someone can look into, as I am not getting much time to finish it off

@ilstefano
Copy link
Author

I can do so. I guess I'll first define the permission spec for Projects in Models/perm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants