Conversation
dingo35
left a comment
dingo35
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Few remarks ....
SmartEVSE-3/data/update2.html
Outdated
| <td>Factory</td> | ||
| <td>stable</td> | ||
| <td><a href="https://github.com/" | ||
| <td><a href="https://github.com/SmartEVSE/SmartEVSE-3" |
There was a problem hiding this comment.
I think this will cause a problem; this reference (called this.href) will have "OWNER_FACT + / + REPO _FACT added to it, so the link would become:
https://github.com/SmartEVSE/SmartEVSE-3/SmartEVSE/SmartEVSE-3 ....
There was a problem hiding this comment.
Well, if that was the case this would not need a fix 🙂
I came across this in the /update page. Both links just brought me to GitHub.com
So I assumed this would fix it. But I'm not very familiar with html
There was a problem hiding this comment.
Well thats strange, in all of my versions, if you hover your mouse over the link it SHOWS https://github.com but if you click it it actually brings you to the right repository (dingo35/SmartEVSE-3.5 or SmartEVSE/SmartEVSE-3.5).
Does yours behave differently? If so, what browser do you use?
There was a problem hiding this comment.
Seems you are correct. I was assuming the hovering url was also where it would take me.
I will adjust the PR accordingly!
There was a problem hiding this comment.
Well if you use right mouse and open link in new tab, this will take you to just github.com, instead of the full url.
SmartEVSE-3/data/update2.html
Outdated
| <td>Community          </td> | ||
| <td>bleeding edge       </td> | ||
| <td><a href="https://github.com/" | ||
| <td><a href="https://github.com/dingo35/SmartEVSE-3.5" |
dingo35
left a comment
dingo35
left a comment
There was a problem hiding this comment.
In my environment it doesnt change anything, still showing "github.com" when hovering over the github repo fields.
I am on Firefox on Linux, which automatically favores https://
| onclick="var fullUrl = this.href + OWNER_COMM + '/' + REPO_COMM + '/releases'; | ||
| this.title = fullUrl; // Update hover text | ||
| location.href = fullUrl; | ||
| return false;"><script>document.write(OWNER_COMM)</script></a></td> |
There was a problem hiding this comment.
Please align this code according to the change you made above. Small thing but it helps the code looking good!
dingo35
force-pushed
the
master
branch
2 times, most recently
from
6ca5aa2 to
8a96828
Compare
3 participants
No description provided.