Conversation
LK
approved these changes
Feb 10, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| runs-on: ubicloud-standard-30-ubuntu-2204 | ||
| container: | ||
| image: ghcr.io/diodeinc/kicad:9.0.7-trixie-full | ||
| options: --user root |
There was a problem hiding this comment.
Windows E2E test coverage silently dropped during migration
Medium Severity
The PR title says "Move e2e tests to a separate workflow," but the new e2e.yml matrix only includes macOS and Ubuntu, while the old test.yml also ran the e2e steps (build examples, bom/layout/publish CLI tests, and stdlib builds) on Windows. This silently drops Windows E2E test coverage. The old workflow even had Windows-specific KiCad cache and install steps, confirming Windows e2e was intentionally supported before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
CI-only refactor that changes workflow structure and execution environment, with primary risk being missed coverage or differing behavior between the new E2E job and the removed steps.
Overview
Splits CLI end-to-end coverage into a new GitHub Actions workflow,
e2e.yml, which runs on macOS and Ubuntu (Ubuntu via the KiCad container) and executespcbbuild/example/workspace/new/stdlib build scenarios.Updates
test.ymlto focus on unit/workspace tests (plus existing lint/python/readme checks) by removing the prior E2E CLI steps and associated build/example/stdlib invocations from the maintestjob.Written by Cursor Bugbot for commit 638e638. This will update automatically on new commits. Configure here.