Conversation
8abd0a5 to
eaadc10
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| brew install --cask kicad | ||
|
|
||
| - name: Cache KiCad (Windows) | ||
| if: matrix.config.name == 'Windows' |
There was a problem hiding this comment.
Dangling reference to removed cache step breaks condition
Medium Severity
The "Cache KiCad (Windows)" step with id cache-kicad-windows was removed, but the "Install KiCad (Windows)" step's if condition still references steps.cache-kicad-windows.outputs.cache-hit. Since that step no longer exists, the expression evaluates to '' != 'true' which is always true, causing choco install kicad to run on every workflow execution. On a self-hosted runner where KiCad is presumably pre-installed, this results in unnecessary reinstallation every time.


Note
Medium Risk
CI behavior changes may cause Windows jobs to fail or run slower depending on self-hosted runner availability/configuration and the removed KiCad cache.
Overview
Moves the CI Windows test matrix to a self-hosted runner by changing
runs-onfromwindows-largeto[self-hosted, windows-large].Removes the Windows KiCad cache step from the workflow, leaving Windows KiCad installation to run without
actions/cache.Written by Cursor Bugbot for commit eaadc10. This will update automatically on new commits. Configure here.