Skip to content

Harden pcb import passive value parsing#533

Merged
akhilles merged 1 commit intomainfrom
debug-import
Feb 12, 2026
Merged

Harden pcb import passive value parsing#533
akhilles merged 1 commit intomainfrom
debug-import

Conversation

@akhilles
Copy link
Contributor

@akhilles akhilles commented Feb 12, 2026

Note

Low Risk
Localized parsing changes with expanded unit tests; risk is mainly small behavior shifts for ambiguous value strings during import.

Overview
Improves pcb import passive (R/C) value parsing so generic auto-promotion is more consistent across real-world BOM/value strings.

Parsing is hardened by tokenizing on additional separators (e.g. /, parentheses, brackets), normalizing Unicode and locale variants (Greek mu, ohm symbol variants, comma decimals), supporting resistor R10-style fractional notation, and attempting merged-token parses while avoiding accidental refdes/package merges (e.g. standalone R + 0402). Tests are expanded to cover these cases, and the fix is documented in the Unreleased changelog.

Written by Cursor Bugbot for commit ff0e6b0. This will update automatically on new commits. Configure here.

@akhilles akhilles requested a review from LK February 12, 2026 16:15
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@akhilles akhilles merged commit 3f4d69f into main Feb 12, 2026
12 checks passed
@akhilles akhilles deleted the debug-import branch February 12, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants