Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
LK
approved these changes
Feb 17, 2026
Also, only rewrite the subset of the layout file we're patching. Not the whole thing. We were already using this strategy for net rename and other Rust-based kicad file patching. We should use it for board config patching as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, only rewrite the subset of the layout file we're patching. Not the whole thing. We were already using this strategy for net rename and other Rust-based kicad file patching. We should use it for board config patching as well.
Note
Medium Risk
Touches layout file patching/formatting logic and changes how
.kicad_pcbcontent is rewritten; errors could cause malformed boards or noisy diffs, though changes are localized and covered by new tests.Overview
pcb layoutstackup sync now also patchesgeneral (thickness ...)using a computed board thickness (including KiCad’s fixed solder mask contribution) and formats the value in KiCad-style mm text.Stackup/layers syncing is refactored to generate a
PatchSetthat replaces only the relevant S-expression spans (layers,setup.stackup, andgeneral.thickness) and then runsprettify, reducing unrelated churn compared to reformatting the entire parsed tree.pcb-sexprparsing/formatting is extended to preserve original numeric lexemes (e.g.12.000000) via a newraw_atomfield, ensuring round-trips and targeted patches don’t normalize unrelated numeric precision.Written by Cursor Bugbot for commit d5d5a1c. This will update automatically on new commits. Configure here.