Validate pin identifiers in Component pins map#555
Closed
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| starlark::Error::new_other(anyhow!("pin names must be strings")) | ||
| })? | ||
| .to_owned(); | ||
| validate_identifier_name(&signal_name, "Pin name")?; |
There was a problem hiding this comment.
Missing pin name validation in pin_defs path
Medium Severity
The new validate_identifier_name call validates pin names from the pins dict but not from the pin_defs dict. Since pin_defs keys become signal names in the symbol, a user can define a pin with a dot (e.g. pin_defs = {"NC.1": "1"}) and the invalid name enters the system unchecked. Worse, if that pin is later referenced in pins, the validation rejects it — creating pins that are definable but unconnectable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


We shouldn't allow
.in pin names as parsing it becomes ambiguous.Note
Low Risk
Small, localized validation change that may surface new errors for designs previously using dotted/invalid pin names, but does not affect security or data integrity.
Overview
Component(pins=...)now validates each pin name usingvalidate_identifier_name, rejecting non-identifier keys (ASCII-only, non-empty, no whitespace, and disallowing./@) at component construction time.Tests add a lightweight
eval_single_filehelper and a new regression test that asserts dotted pin names fail evaluation, and docs/CHANGELOG.mdare updated to document the new pin-name constraint.Written by Cursor Bugbot for commit 2726298. This will update automatically on new commits. Configure here.