Skip to content

Fix publish layout sync false positives#556

Merged
akhilles merged 1 commit intomainfrom
fix/sync-diff
Feb 19, 2026
Merged

Fix publish layout sync false positives#556
akhilles merged 1 commit intomainfrom
fix/sync-diff

Conversation

@akhilles
Copy link
Contributor

@akhilles akhilles commented Feb 19, 2026

Note

Low Risk
Narrowly scoped normalization around file comparisons and .kicad_pro output formatting; main risk is potentially missing a meaningful change if it only differs by trailing whitespace.

Overview
Reduces layout.sync false positives during pcb publish/--check by treating synced KiCad layout files as equal when they only differ in trailing whitespace.

This changes pcb-layout's drift detection to compare file contents after trimming ASCII whitespace at EOF, and updates pcb release’s .kicad_pro writer to always end the pretty-printed JSON with a newline. Targeted unit tests were added for both behaviors, and the fix is documented in the changelog.

Written by Cursor Bugbot for commit d70f0d6. This will update automatically on new commits. Configure here.

@akhilles akhilles requested a review from LK February 19, 2026 01:30
@akhilles akhilles merged commit 2ea1e6d into main Feb 19, 2026
12 checks passed
@akhilles akhilles deleted the fix/sync-diff branch February 19, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants