Add symbol-driven default footprint inference in Component()#559
Merged
Add symbol-driven default footprint inference in Component()#559
Component()#559Conversation
LK
approved these changes
Feb 19, 2026
| use std::path::PathBuf; | ||
| use std::sync::Arc; | ||
|
|
||
| fn eval_with_files( |
Contributor
There was a problem hiding this comment.
Would these be cleaner as snapshot_eval! tests?
681c7bc to
4facf45
Compare
4facf45 to
7afdb29
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
7afdb29 to
8feabb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes component construction semantics and footprint resolution paths, which can affect evaluation/build/netlist output when symbols or dependencies are missing or mis-specified.
Overview
Component()now accepts an omittedfootprintand will infer it from a file-backed symbol’sFootprintproperty, first by treating it as a local<stem>(or legacy<stem>:<stem>) resolved to<symbol_dir>/<stem>.kicad_mod, and then (when an eval context exists) by mapping KiCad’s<lib>:<fp>to the KiCad footprints package and resolving via declared dependencies before normalizing topackage://URIs.pcb search/component finalization now rewrites symbolFootprintproperties to the local stem form (instead oflib:fp), and the PR adds focused unit/integration tests and snapshots for inference success/failure cases, updates the language spec, refreshes examples to rely on inference, and bumps examplepcb.tomlassets accordingly.Written by Cursor Bugbot for commit 8feabb8. This will update automatically on new commits. Configure here.