Prefer raw external tools during discovery (disable nested code-mode)#560
Merged
Prefer raw external tools during discovery (disable nested code-mode)#560
Conversation
Top-level code-mode can still use the discovered mcp tools.
LK
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top-level code-mode can still use the discovered mcp tools.
Note
Low Risk
Low risk: small change to external MCP process spawning/discovery logic with a straightforward fallback path; main risk is compatibility with older backends that behave differently under
--code-mode=false.Overview
External MCP tool discovery now spawns
pcb-*backends usingmcp --code-mode falseto avoid nested code-mode wrappers, falling back to plainmcpwhen the flag isn’t supported.ExternalMcpServer::spawnwas refactored to try multiple MCP CLI argument sets via a newspawn_with_mcp_argshelper, and the change is documented inCHANGELOG.md.Written by Cursor Bugbot for commit a4c7a34. This will update automatically on new commits. Configure here.