Fix pcb update behavior for kicad-style asset dependencies#602
Merged
Fix pcb update behavior for kicad-style asset dependencies#602
pcb update behavior for kicad-style asset dependencies#602Conversation
Build Performance
Measured with hyperfine. Times show median ±stddev. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
LK
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore release candidates, and resolve MVS before materialization.
Note
Medium Risk
Touches dependency resolution and update selection paths; incorrect version propagation could break KiCad asset aliasing or cause unexpected update behavior, but changes are scoped and covered by targeted tests.
Overview
Fixes KiCad asset handling so MVS-selected versions are consistently used during resolution: legacy
[assets]entries are promoted into implicit[dependencies], sibling repo promotion anchors to an already-resolved sibling’s version, and asset materialization/resolution mapping now takes an explicitselected_kicad_assetsset.Updates
pcb updateversion picking to ignore prerelease tags (e.g.,-rc) when selecting both non-breaking and breaking candidates, and adds tests for the new asset-version and prerelease behaviors (plus changelog entries).Written by Cursor Bugbot for commit 726f2bd. This will update automatically on new commits. Configure here.