Skip to content

Fix pcb update behavior for kicad-style asset dependencies#602

Merged
akhilles merged 3 commits intomainfrom
fix/pcb-update
Mar 4, 2026
Merged

Fix pcb update behavior for kicad-style asset dependencies#602
akhilles merged 3 commits intomainfrom
fix/pcb-update

Conversation

@akhilles
Copy link
Contributor

@akhilles akhilles commented Mar 4, 2026

Ignore release candidates, and resolve MVS before materialization.


Note

Medium Risk
Touches dependency resolution and update selection paths; incorrect version propagation could break KiCad asset aliasing or cause unexpected update behavior, but changes are scoped and covered by targeted tests.

Overview
Fixes KiCad asset handling so MVS-selected versions are consistently used during resolution: legacy [assets] entries are promoted into implicit [dependencies], sibling repo promotion anchors to an already-resolved sibling’s version, and asset materialization/resolution mapping now takes an explicit selected_kicad_assets set.

Updates pcb update version picking to ignore prerelease tags (e.g., -rc) when selecting both non-breaking and breaking candidates, and adds tests for the new asset-version and prerelease behaviors (plus changelog entries).

Written by Cursor Bugbot for commit 726f2bd. This will update automatically on new commits. Configure here.


Open with Devin

@akhilles akhilles requested a review from LK March 4, 2026 06:23
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Build Performance

Board Base (median) Head (median) Change
demo/DM0001 117ms ±3 114ms ±4 -2.3%
demo/DM0002 100ms ±2 103ms ±1 +3.0%
demo/DM0003 113ms ±2 115ms ±2 +1.9%
arduino/Nano 78ms ±0.9 85ms ±3 1.10× ±0.03 slower
arduino/UNOQ 168ms ±8 168ms ±9 +0.2%

Measured with hyperfine. Times show median ±stddev.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@akhilles akhilles merged commit 72c4ca1 into main Mar 4, 2026
12 checks passed
@akhilles akhilles deleted the fix/pcb-update branch March 4, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants