Working with robots under a different namespace#17
Open
RaduCorcodel wants to merge 1 commit intodiogoalmeida:masterfrom
Open
Working with robots under a different namespace#17RaduCorcodel wants to merge 1 commit intodiogoalmeida:masterfrom
RaduCorcodel wants to merge 1 commit intodiogoalmeida:masterfrom
Conversation
…orking with robots under their own ns.
Owner
|
Thanks! I will try to look into this with some care, as I think that this change breaks some use cases I have, but I'm not fully sure yet. Perhaps its a good motivation for me to address #9 as well. |
Author
|
Not a problem, take your time. Sorry for the delay; I wanted to submit this PR long time ago, just that I've just been swamped with RSS and then IROS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic_control_toolbox must use a relative name for robot_description so we can roslaunch under the same namespace as the robot is in.