Skip to content

RF: Fixed Schedule js issue & more #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skoudoro merged 1 commit into from
Nov 6, 2025
Merged

RF: Fixed Schedule js issue & more #41

skoudoro merged 1 commit into from
Nov 6, 2025

Conversation

@deka27
Copy link
Member

@deka27 deka27 commented Nov 5, 2025 •
edited
Loading

  1. Fixed issue where carousel functionality was active on desktop view for schedule. (restricted to mobile)
  2. About section has been updated, more concise & impactful paragraph
  3. Why attend section - Removed the numbers from the image card
  4. Update schedule section

@github-actions
Copy link

github-actions bot commented Nov 5, 2025 •
edited
Loading

🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/workshop.dipy.org/pull/41/

@maharshi-gor
Copy link
Member

maharshi-gor commented Nov 5, 2025

Hi @deka27

Please remove this -- from the line

5 days of hands-on diffusion MRI training. Zero to hero—no coding experience required, just curiosity!

This gives off for having generated from the AI tool.

@maharshi-gor
Copy link
Member

maharshi-gor commented Nov 5, 2025

@deka27

Please use this,

  .. workshop-speaker::
    :name: Jaroslaw Harezlak
    :image: jarek.jpeg
    :title: DIPY Advisor on Statistics
    :affiliation: Professor, Indiana University

@maharshi-gor
Copy link
Member

maharshi-gor commented Nov 5, 2025 •
edited
Loading

@deka27

Can you also update the photo for Rafael from this link

https://ibeb.ciencias.ulisboa.pt/rafael-neto-henriques/

and make sure not photos are stretched. I saw Jarek's photo is stretched a little. But we need to update it for Rafael for sure.

You can redownload the image from this link

https://stat.indiana.edu/about/faculty/adjunct-faculty/harezlak-jaroslaw.html

Let's make sure this images look really good in the new design.

skoudoro
skoudoro reviewed Nov 5, 2025
View reviewed changes
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below some additional comments to fix

skoudoro
skoudoro reviewed Nov 6, 2025
View reviewed changes
2026.rst Outdated
:name: Garyfallidis Research Group (GRG)
:image: _static/images/universities/GRG.png
:url: https://grg.luddy.indiana.edu/
:note: Multiple speakers including <b>Garyfallidis and Harezlak</b> are funded by the <br/><a href="https://www.nih.gov/">National Institutes of Health</a>.<br/> In addition, <b>Koudoro and Rokem</b> are funded froman EOSS grant through the <br/><a href="https://chanzuckerberg.com/eoss/proposals/strengthening-computational-neuroanatomy-using-dipy/">Chan Zuckerberg Initiative</a>.
Copy link
Member

@skoudoro skoudoro Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

froman ??? typo ?

Copy link
Member Author

@deka27 deka27 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, missed the space there.

Copy link
Member

@skoudoro skoudoro Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, can I go ahead and merge ?

Copy link
Member Author

@deka27 deka27 Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea.. sorry.. saw the message today. I squashed the commit. You can go ahead n merge. @skoudoro

skoudoro
skoudoro approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, merging

@skoudoro skoudoro merged commit 3101a69 into dipy:main Nov 6, 2025
3 checks passed
@deka27 deka27 deleted the fixes_site branch November 6, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skoudoro skoudoro skoudoro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deka27 @maharshi-gor @skoudoro