-
Notifications
You must be signed in to change notification settings - Fork 10
464 implement frontend javascript testing #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbland
wants to merge
10
commits into
main
Choose a base branch
from
464-implement-frontend-javascript-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b209e1f
Implement tests and some tidying up
sbland 7ddad5a
Move frontend node docs from README.md to node/README.md
sbland 212805c
Add docs about running node vitest
sbland 5c929c5
Update node readme
sbland 6e74b5c
Some linting amends
sbland a0af0bd
Add tests for radial plot dataprocessing
sbland decf26d
Add a github action to run node tests
sbland 58ab9c4
Fix node version in ci
sbland eb03141
Fix left .only in tests
sbland 053c4be
Update README.md
sbland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,62 @@ | ||
| module.exports = { | ||
| // Add rules for JavaScript files | ||
| env: { | ||
| browser: true, | ||
| es6: true, | ||
| node: true, | ||
| }, | ||
| extends: ['eslint:recommended', 'plugin:prettier/recommended', 'plugin:storybook/recommended'], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:prettier/recommended', | ||
| 'plugin:storybook/recommended', | ||
| ], | ||
| plugins: ['prettier'], | ||
| parserOptions: { | ||
| ecmaVersion: 13, | ||
| sourceType: 'module', | ||
| }, | ||
| rules: { | ||
| 'prettier/prettier': 'error', | ||
| indent: ['error', 2], | ||
| // indent: ['error', 2], // Disabled as it conflicts with Prettier | ||
| semi: ['error', 'never'], | ||
| 'no-var': 'error', | ||
| }, | ||
| overrides: [ | ||
| { | ||
| // Add rules for Test files | ||
| files: ['**/*.test.{js}'], | ||
| env: { | ||
| browser: true, | ||
| es6: true, | ||
| node: true, | ||
| }, | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:prettier/recommended', | ||
| 'plugin:storybook/recommended', | ||
| ], | ||
| plugins: ['prettier'], | ||
| parserOptions: { | ||
| ecmaVersion: 13, | ||
| sourceType: 'module', | ||
| }, | ||
| rules: { | ||
| 'prettier/prettier': 'error', | ||
| // indent: ['error', 2], // Disabled as it conflicts with Prettier | ||
| semi: ['error', 'never'], | ||
| 'no-var': 'error', | ||
| }, | ||
| // Include testing globals for vitest | ||
| globals: { | ||
| vi: true, | ||
| describe: true, | ||
| it: true, | ||
| expect: true, | ||
| beforeEach: true, | ||
| afterEach: true, | ||
| beforeAll: true, | ||
| afterAll: true, | ||
| }, | ||
| }, | ||
| ], | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Node - CI - Lint and Test | ||
|
|
||
| on: | ||
| # Trigger the workflow on push or pull request, | ||
| # but only for the main branch | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| run-tests: | ||
| name: Run tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: '22' | ||
| - name: Check out Git repository | ||
| uses: actions/checkout@v4 | ||
| - name: Install dependencies | ||
| run: npm install | ||
| - name: Run tests | ||
| run: npm run test-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| { | ||
| "trailingComma": "es5", | ||
| "tabWidth": 2, | ||
| "indent": 4, | ||
| "semi": false, | ||
| "singleQuote": true, | ||
| "endOfLine": "auto" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/direct-framework/direct-webapp/blob/main/node/README.md Status: 404