Open
Conversation
Collaborator
There was a problem hiding this comment.
This is great, can you add a test_provides_required_context type of test for the index view? I think that then covers all the missing ones.
It might even be worth making a mixin class for that test, because it seems relatively standard. but if they differ enough to make it tricky then don't bother
tests/main/test_main_views.py
Outdated
|
|
||
| from django.urls import reverse | ||
|
|
||
| from main.models import Competency, CompetencyDomain, Skill, SkillLevel, UserSkill |
Collaborator
There was a problem hiding this comment.
This is currently imported inside one of the pre-existing tests. It's probably best to keep it here, can you delete it from the other one?
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tests for the following views.
Fixes #543
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks