refactor(auth): use CLI-based authentication for GCE and Azure#419
Merged
refactor(auth): use CLI-based authentication for GCE and Azure#419
Conversation
- GCE: Replace JSON keyfile auth with Application Default Credentials (ADC) - Azure: Remove unused authFile parameter from NewAzure() - Update golangci-lint config to v2 format - Document breaking changes in README Signed-off-by: Engin Diri <engin.diri@ediri.de>
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authFileparameter from Azure'sNewAzure()functionBreaking Changes
GCE
NewGCE(keyfile, zone string)changed toNewGCE(zone string)GCE_KEYenvironment variable is no longer usedGOOGLE_PROJECTandGOOGLE_SERVICE_ACCOUNT_EMAILGOOGLE_APPLICATION_CREDENTIALSfor service account JSON (if not usinggcloud auth application-default login)Azure
NewAzure(authFile string)changed toNewAzure()AZURE_AUTH_LOCATIONenvironment variable is no longer used (it was never actually used in the implementation)Test plan
go build ./...passesgo test ./...passes