fix windows support by removing unsupported dir characters #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
garymathews
commented
Nov 6, 2025
garymathews
commented
- Directories with * characters are not supported on Windows, the challenge directories fail to be created
BlvckParrot
added a commit
to BlvckParrot/shadowharvester
that referenced
this pull request
Nov 6, 2025
Owner
|
Does moving the challenges into sled solve this for you, or would you like to proceed with adding this (only on windows so it doesn't break other people's saved challenges)? |
Contributor
Author
|
I included attributes so it doesn't break existing challenges on other target OS: The changes in this PR are still required for this to run on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.