Add helper for PSR-16/void-cache #1190
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQKo
force-pushed
the
psr16-void-cache
branch
from
12f4f1b to
17f924d
Compare
Exanlv
reviewed
Apr 24, 2024
Comment on lines
+38
to
+44
| $result = []; | ||
|
|
||
| foreach ($keys as $key) { | ||
| $result[$key] = $default; | ||
| } | ||
|
|
||
| return $result; |
There was a problem hiding this comment.
Suggested change
| $result = []; | |
| foreach ($keys as $key) { | |
| $result[$key] = $default; | |
| } | |
| return $result; | |
| return array_fill_keys($keys, $default); |
Though not sure if it accepts iterable, so maybe this instead?
Suggested change
| $result = []; | |
| foreach ($keys as $key) { | |
| $result[$key] = $default; | |
| } | |
| return $result; | |
| return array_fill_keys(iterator_to_array($keys), $default); |
There was a problem hiding this comment.
I thought of this before, but i changed my mind
Now i forgot why i changed my mind, it was probably something with the object's getIterator() implementation and the use of Generator, but not sure which
Exanlv
approved these changes
Apr 24, 2024
valzargaming
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A void/null cache class for PSR-16/SimpleCache implementation
might want to have its own repo