Fix interactions failing with JsonResponse class
#75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Commit Message ``` fix: ensure Content-Type header always set in JsonResponse Fix header merging logic preventing Discord interaction responses ``` ## PR Description **Problem:** Discord interactions failing with `JsonResponse` class **Root Cause:** Header initialization bug - when `init` object passed, `||` operator ignored JSON content-type header **Fix:** Use object spread to properly merge headers while ensuring Content-Type is always set
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
PR Description
Problem: interactions failing with
JsonResponseclassRoot Cause: Header initialization bug - when
initobject passed,||operator ignored JSON content-type headerFix: Use object spread to properly merge headers while ensuring Content-Type is always set