Skip to content

openExternalLink returns a { opened: boolean | null } result #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2024
Merged

openExternalLink returns a { opened: boolean | null } result #7273

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b309ebd
Add a response type for openExternalLink that returns a boolean opene…
HamzaAtDiscord Nov 14, 2024
7251a1c
updating the documentation to include the null case for older discord…
HamzaAtDiscord Nov 18, 2024
64339f8
doc update
HamzaAtDiscord Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/developer_tools/Embedded_App_SDK.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ No scopes required
#### Signature

<Monospace>
openExternalLink(args: [OpenExternalLinkRequest](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/openexternallinkrequest)): Promise\<void\>
openExternalLink(args: [OpenExternalLinkRequest](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/openexternallinkrequest)): Promise\<[OpenExternalLinkResponse](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/openexternallinkresponse)\>
</Monospace>

#### Usage
Expand Down Expand Up @@ -1335,6 +1335,15 @@ No scopes required
|----------|--------|
| url | string |

#### OpenExternalLinkResponse

> warn
> `{ opened: null }` is returned on Discord clients before December 2024 that do not report the open link result.

| Property | Type |
|----------|-----------------|
| opened | boolean \| null |

#### OpenInviteDialogRequest

| Property | Type |
Expand Down