Skip to content

Entitlement: Update ends_at and starts_at to be nullable, not optional #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Entitlement: Update ends_at and starts_at to be nullable, not optional #7288

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a2475
Update ends_at and starts_at to be nullable, not optional
colinloretz Nov 26, 2024
4c280af
Fix ends_at, starts_at description for test entitlements
colinloretz Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions docs/resources/Entitlement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ Refer to the [Monetization Overview](#DOCS_MONETIZATION_OVERVIEW) for more infor

###### Entitlement Structure

| Field | Type | Description |
|----------------|-------------------|---------------------------------------------------------------------------------------------|
| id | snowflake | ID of the entitlement |
| sku_id | snowflake | ID of the SKU |
| application_id | snowflake | ID of the parent application |
| user_id? | snowflake | ID of the user that is granted access to the entitlement's sku |
| type | integer | [Type of entitlement](#DOCS_RESOURCES_ENTITLEMENT/entitlement-object-entitlement-types) |
| deleted | boolean | Entitlement was deleted |
| starts_at? | ISO8601 timestamp | Start date at which the entitlement is valid. Not present when using test entitlements. |
| ends_at? | ISO8601 timestamp | Date at which the entitlement is no longer valid. Not present when using test entitlements. |
| guild_id? | snowflake | ID of the guild that is granted access to the entitlement's sku |
| consumed? | boolean | For consumable items, whether or not the entitlement has been consumed |
| Field | Type | Description |
|----------------|--------------------|---------------------------------------------------------------------------------------------|
| id | snowflake | ID of the entitlement |
| sku_id | snowflake | ID of the SKU |
| application_id | snowflake | ID of the parent application |
| user_id? | snowflake | ID of the user that is granted access to the entitlement's sku |
| type | integer | [Type of entitlement](#DOCS_RESOURCES_ENTITLEMENT/entitlement-object-entitlement-types) |
| deleted | boolean | Entitlement was deleted |
| starts_at | ?ISO8601 timestamp | Start date at which the entitlement is valid. Not present when using test entitlements. |
| ends_at | ?ISO8601 timestamp | Date at which the entitlement is no longer valid. Not present when using test entitlements. |
Copy link
Contributor

@Jiralite Jiralite Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not present when using test entitlements.

I believe this should be amended if this is always present, or null, or otherwise?

Copy link
Contributor Author

@colinloretz colinloretz Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, thank you! We should have updated these for the entitlement migration but they were missed.

| guild_id? | snowflake | ID of the guild that is granted access to the entitlement's sku |
| consumed? | boolean | For consumable items, whether or not the entitlement has been consumed |

###### Entitlement Example

Expand Down