remove redundant question marks for channel update params #7333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR also removes |
Author
Good catch! I'll update that |
colinloretz
approved these changes
Jan 10, 2025
mazylol
pushed a commit
to mazylol/discord-api-docs
that referenced
this pull request
Jul 3, 2025
* remove redundant question marks for channel update params * Moved optional param note to info callout --------- Co-authored-by: Colin Loretz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the JSON fields for the channel update payload are all optional, either all of the fields or none of the fields in the table should have the
?which indicates optionality. I chose to remove the?for all of them, so developers can refer to this highlighted part of the doc as the source of truth.