-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: pre-commit hook #7428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pre-commit hook #7428
Conversation
| npm run fix:tables | ||
| npm run test:links | ||
| npm run test:build | ||
| git update-index --again No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not need to run test:build here in the pre-commit, since it generates a big chunk of text while committing, and we already run that in the CI
36e73ea to
46c964c
Compare
Not sure if this is actually needed, doing a separate commit to ensure we can revert this easily.
ckohen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Ty for this, I know it's been open for a while but we're going to keep this manual for now |
No more headache when working with tables
Details
Uses: https://typicode.github.io/husky/ (https://github.com/typicode/husky)
Runs on:
git commitWill be skipped on ci-runs
Runs:
fix:tables,test:links&test:build(For Colin :D)
Notes
test:linksfails. It only outputs that there's an error. But this is intended since the CI should block that."prepare": "npx is-ci || npx husky"is-ciwill be true if executed on github actions, skipping the husky run if neededgit update-index --againis added to.husky/pre-committo commit the fixed tablestest:build