Make images/ a lot smaller #7452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpetryk
commented
Apr 4, 2025
Contributor
Author
There was a problem hiding this comment.
y'all use pnpm now, deal with it (jk I will revert all the scripty stuff)
Contributor
|
huge |
JustinBeckwith
approved these changes
Apr 4, 2025
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
LGTM after going back to npm
Contributor
|
Booted up a local preview and poked around, LGTM!
|
markmandel
approved these changes
Apr 4, 2025
Contributor
|
btw I think some of the images (like ask-to-join.gif) aren't used at all and can be removed |
Contributor
|
Deferring to #7742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall size reduction: 147MB -> 49MB.
The 33MB worth of GIGANTIC gifs in
images/social-sdk/design-guidelines/animatedwill need special treatment, maybe placed on our internal CDN, because they are just huge and displayed in a large format. Any attempt at optimizing them makes them look like crap.