Mark optional fields as nullable for Activity RP #7471
Merged
+46
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydiscord
requested changes
Apr 15, 2025
docs/developer-tools/game-sdk.mdx
Outdated
| |----------|---------------|----------------------------------------------| | ||
| | match | string | null | unique hash for the given match context | | ||
| | join | string | null | unique hash for chat invites and Ask to Join | | ||
| | spectate | string | null | unique hash for Spectate button | |
Contributor
There was a problem hiding this comment.
Adding the | character here as an "or" ends up breaking the table and we lose the descriptions. This happened in each of the tables where this change was made. I think you could do string?, or, or \| to escape it as a few options.
Member
There was a problem hiding this comment.
we use string? to denote a nullable string
Contributor
There was a problem hiding this comment.
actually it's ?string
https://discord.com/developers/docs/reference#nullable-and-optional-resource-fields
anthonydiscord
approved these changes
Apr 16, 2025
goatslacker
force-pushed
the
goatslacker/rp-optional-fields
branch
from
85d07ad to
bc136b2
Compare
mazylol
pushed a commit
to mazylol/discord-api-docs
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.