More voice disconnect reasons

[vassjozsef]

No description provided.

[advaith1]

Can the "description" values be made unique? that field is used as the opcode name in enums

[MinnDevelopment]

Why does this get sent when the user was the last connected one (see #7575)? Is that an oversight? Why does changing the voice server imply you shouldn't reconnect? That seems strange to me.

[MinnDevelopment]

The way we observe this close code implies 3 different scenarios (might be more idk what else is hidden behind "etc." here).

1. Bot is kicked and channel is now empty -> no reconnect
2. Channel is deleted -> no reconnect
3. Voice server changed -> connect to new voice server (essentially reconnect with extra steps)

This means the client has to decide based on context information how to handle this closure. Which makes implementation unnecessarily difficult. I would expect all these scenarios to use different close codes.

1. Should be 4014 as usual for voice kicks
2. Can be 4022 (Channel deleted / User removed from guild / Channel no longer accessible / etc.)
3. Should be a different code like 4023 (voice server changed), which can be handled differently.

Unless I'm completely misreading these docs, which means they can be improved.

[topi314]

Disconnect due to rate limit exceeded

There are no mentions of rate limits in the voice docs.
Can we get more information on this?

[topi314]

Suggested change

	| 4022 | Disconnected: Call Terminated | Disconnect all clients due to call terminatedc (channel deleted, voice server changed, etc.). Should not reconnect. |
	| 4022 | Disconnected: Call Terminated | Disconnect all clients due to call terminated (channel deleted, voice server changed, etc.). Should not reconnect. |

[vassjozsef]

Thank you, fixed.

[vassjozsef]

Can the "description" values be made unique? that field is used as the opcode name in enums

Done.

[Rapptz]

Suggested change

	| 4022 | Disconnected: Call Terminated | Disconnect all clients due to call terminated (channel deleted, voice server changed, etc.). Should not reconnect. |
	| 4022 | Disconnected: Call Terminated | Disconnect all clients due to call termination (channel deleted, voice server changed, etc.). Should not reconnect. |

"terminated" is bad grammar here.

[ferrenza]

Hey, I’d like to add a bit:
If there's no user in the voice channel except ourselves, and we move ourselves to another channel, the status code that appears will always be 4022.
But if the voice channel has at least 1 other user in it when we move ourselves, then it will first trigger a 4014, and when we return to the previous channel, the code that appears will be 4022.

Example: self move to other channels

🟢 (VC has at least 1 person)
Channel A → Channel B (4014)
Channel B → Channel A (4022)

🔴 (Nobody inside VC)
Channel A → Channel B (4022)
Channel B → Channel A (4022)

[vassjozsef]

Hey, I’d like to add a bit: If there's no user in the voice channel except ourselves, and we move ourselves to another channel, the status code that appears will always be 4022. But if the voice channel has at least 1 other user in it when we move ourselves, then it will first trigger a 4014, and when we return to the previous channel, the code that appears will be 4022.

Example: self move to other channels

🟢 (VC has at least 1 person) Channel A → Channel B (4014) Channel B → Channel A (4022)

🔴 (Nobody inside VC) Channel A → Channel B (4022) Channel B → Channel A (4022)

Yes you are correct. One reason for call terminated is last client leaving the call.