Skip to content

fix: CV2 File Display Component is missing name & size #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

fix: CV2 File Display Component is missing name & size #7609

merged 2 commits into from
Jun 12, 2025

Conversation

@Lulalaby
Copy link
Contributor

@Lulalaby Lulalaby commented Jun 10, 2025 •
edited
Loading

@Lulalaby Lulalaby requested a review from a team as a code owner June 10, 2025 23:17
@Lulalaby Lulalaby requested review from markmandel and removed request for a team June 10, 2025 23:17
@Lulalaby Lulalaby mentioned this pull request Jun 10, 2025
Merged
9 tasks
@Lulalaby Lulalaby changed the title fix: CV2 File Display Component is missing name & size CV2 Fixes Jun 10, 2025
@Lulalaby Lulalaby changed the title CV2 Fixes fix: CV2 File Display Component is missing name & size Jun 10, 2025
@anthonydiscord anthonydiscord requested review from anthonydiscord and removed request for markmandel June 11, 2025 00:50
kpodp0ra
kpodp0ra reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@kpodp0ra kpodp0ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name and size are missing in media galleries and thumbnails.

Since these fields are currently undocumented, could we take advantage of that and move them into the file object so they're accessible across all component types?

@Lulalaby
Copy link
Contributor Author

Lulalaby commented Jun 11, 2025

Would love that too, but these fields are exclusive-for and used-by the client to display the file display component correctly
Would be better to create a feature request.

anthonydiscord
anthonydiscord requested changes Jun 12, 2025
View reviewed changes
@anthonydiscord anthonydiscord merged commit 67905f9 into discord:main Jun 12, 2025
4 checks passed
@Lulalaby Lulalaby deleted the cv2-fd-namesize branch June 12, 2025 23:28
@Fleny113 Fleny113 mentioned this pull request Jun 13, 2025
Merged
sebm253 added a commit to disgoorg/disgo that referenced this pull request Jun 13, 2025
@sebm253
Add Name and Size to FileComponent
f7d9242 
discord/discord-api-docs#7609
mazylol pushed a commit to mazylol/discord-api-docs that referenced this pull request Jul 3, 2025
@Lulalaby @anthonydiscord @mazylol
fix: CV2 File Display Component is missing name & size (discord#7609)
4d33d8c 
* fix: CV2 File Display Component is missing name & size

Signed-off-by: Lala Sabathil <[email protected]>

* Update docs/components/reference.mdx

Co-authored-by: Anthony <[email protected]>

---------

Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: Anthony <[email protected]>
ikafly144 added a commit to sabafly/sabafly-disgo that referenced this pull request Aug 30, 2025
@ikafly144
Squashed commit of the following:
cc81d04 
commit 3cb3c74
Author: Toπ <[email protected]>
Date:   Tue Aug 26 08:58:48 2025 +0200

    add support for selects in modals (#158)

commit 1c13eea
Author: davfsa <[email protected]>
Date:   Mon Aug 25 21:42:17 2025 +0200

    fix: multiple gateway logic bugfixes (#468)

commit b5c57a8
Author: Toπ <[email protected]>
Date:   Thu Aug 21 15:03:48 2025 +0200

    fix: implement identify rate limiting for gateway sharding (#467)

commit aa070bf
Author: sebm253 <[email protected]>
Date:   Wed Aug 20 18:19:39 2025 +0200

    Add PermissionPinMessages

    discord/discord-api-docs#7766

commit 7dd438b
Author: Toπ <[email protected]>
Date:   Wed Aug 20 14:16:20 2025 +0200

    fix: ensure open returns on invalid session (#466)

commit 9507a2e
Author: davfsa <[email protected]>
Date:   Wed Aug 20 00:06:29 2025 +0200

    feat: allow passing resume url for proper startup (#465)

commit 562fe73
Author: davfsa <[email protected]>
Date:   Tue Aug 19 22:01:48 2025 +0200

    feat: add support for new RATE_LIMIT gateway event (#464)

commit ac49b29
Author: topi314 <[email protected]>
Date:   Tue Aug 19 20:42:37 2025 +0200

    refactor: use context in logger calls for gateway operations

commit 4d7a156
Author: Toπ <[email protected]>
Date:   Tue Aug 19 00:07:42 2025 +0200

    Add status check before sending to gateway (#462)

commit b9359df
Author: topi314 <[email protected]>
Date:   Tue Aug 19 00:05:07 2025 +0200

    call close handler on reconnect error

commit 2e5b06b
Author: topi314 <[email protected]>
Date:   Wed Aug 13 01:53:20 2025 +0200

    refactor: change rest.Error to always be returned as a pointer

commit 441f348
Author: Toπ <[email protected]>
Date:   Wed Aug 13 01:45:15 2025 +0200

    fix guild cache logic for unavailable states (#461)

commit b03b02e
Author: Toπ <[email protected]>
Date:   Sun Aug 10 00:19:13 2025 +0200

    Add ResumeShard method and ShardState struct to manage shard session and sequence (#460)

commit ac1984f
Author: topi314 <[email protected]>
Date:   Sun Aug 10 00:15:33 2025 +0200

    fix unknown component with type x received error

commit bb32bd4
Author: topi314 <[email protected]>
Date:   Tue Aug 5 00:15:54 2025 +0200

    pass reconnect variable to gateway close handlers

commit 7ea7ef5
Author: topi314 <[email protected]>
Date:   Mon Aug 4 21:58:23 2025 +0200

    always override shard ids in shard manager config when using WithShardIDs

commit e9d502c
Author: Ankit Malik <[email protected]>
Date:   Fri Aug 1 22:25:00 2025 +0530

    Add ComponentEmoji constructors and builder methods (#459)

commit 0720f59
Author: sebm253 <[email protected]>
Date:   Wed Jul 30 11:10:44 2025 +0200

    Remove guild deletion API

commit 482a53c
Author: sebm253 <[email protected]>
Date:   Wed Jul 30 11:10:03 2025 +0200

    Remove OwnerID from GuildUpdate

commit 73ca7f0
Author: sebm253 <[email protected]>
Date:   Wed Jul 30 11:09:36 2025 +0200

    Add GuildFeatureGuildTags

    discord/discord-api-docs#7710

commit 5e92dd8
Author: sebm253 <[email protected]>
Date:   Mon Jul 28 23:48:03 2025 +0200

    Remove guild creation API

    discord/discord-api-docs#7715

commit e2ee9e3
Author: sebm253 <[email protected]>
Date:   Thu Jul 24 20:16:05 2025 +0200

    Add MemberFlagAutomodQuarantinedGuildTag

    discord/discord-api-docs#7699

commit 22f1edf
Author: sebm253 <[email protected]>
Date:   Wed Jul 23 22:19:15 2025 +0200

    Add AuditLogAutoModerationQuarantineUser

    discord/discord-api-docs#7706

commit b2668c6
Author: sebm253 <[email protected]>
Date:   Sat Jul 19 22:09:27 2025 +0200

    Add new activity fields

    discord/discord-api-docs#7674

commit 1328ec5
Author: sebm253 <[email protected]>
Date:   Wed Jul 2 22:50:54 2025 +0200

    Add email and phone number mentions

    discord/discord-api-docs#7657

commit 01bba29
Author: sebm253 <[email protected]>
Date:   Wed Jul 2 21:13:33 2025 +0200

    Revert "Add UnusualDMActivityUntil to Member"

    This reverts commit 3ab1280.

commit 7532856
Author: Sebastian <[email protected]>
Date:   Wed Jul 2 11:05:10 2025 +0200

    Add guild tags (#353)

    * Add clans

    * fix url

    * rename Clan to PrimaryGuild

    discord/discord-api-docs@82f3d7b

    * rename to guild tag

    ---------

    Co-authored-by: mlnrDev <[email protected]>

commit 3ab1280
Author: sebm253 <[email protected]>
Date:   Tue Jul 1 21:49:02 2025 +0200

    Add UnusualDMActivityUntil to Member

commit b642511
Author: Sebastian <[email protected]>
Date:   Mon Jun 30 23:58:13 2025 +0200

    Add guest invites (#278)

    * Add guest invites

    * rename const

    ---------

    Co-authored-by: mlnrDev <[email protected]>

commit 7c62b71
Author: Sebastian <[email protected]>
Date:   Thu Jun 26 18:43:51 2025 +0200

    Add role gradient colors (#453)

    * reformat imports & update .editorconfig

    * Add role gradient colors

    * i have no idea whats going on

    ---------

    Co-authored-by: topi314 <[email protected]>

commit 6267de0
Author: Sebastian <[email protected]>
Date:   Sat Jun 21 12:21:01 2025 +0200

    Use new pin endpoints (#457)

    * Use new pin endpoints

    * dumbass

    * topi didnt say anything so im pushing this hoping he notices and lets me know

commit 3bfbd77
Author: topi314 <[email protected]>
Date:   Sat Jun 21 12:00:26 2025 +0200

    update dependencies

commit 0af01ec
Author: Norio Nomura <[email protected]>
Date:   Sat Jun 21 18:57:17 2025 +0900

    Merge pull request #458 from norio-nomura/fix-update-current-member-to-return-discord-member

    Fix `Members.UpdateCurrentMember` to return `discord.Member`

commit af333cf
Author: sebm253 <[email protected]>
Date:   Sun Jun 15 23:42:57 2025 +0200

    Add AssetURL to Nameplate

commit 273c3d9
Author: sebm253 <[email protected]>
Date:   Sun Jun 15 22:13:36 2025 +0200

    Add nameplates

    discord/discord-api-docs#7614

commit 80335a6
Author: sebm253 <[email protected]>
Date:   Fri Jun 13 11:45:27 2025 +0200

    Add ApproximateUserAuthorizationCount to Application

    discord/discord-api-docs#7613

commit f7d9242
Author: sebm253 <[email protected]>
Date:   Fri Jun 13 11:35:27 2025 +0200

    Add Name and Size to FileComponent

    discord/discord-api-docs#7609

commit ae72a64
Merge: de575c1 8ac2ef0
Author: sebm253 <[email protected]>
Date:   Thu Jun 12 22:52:04 2025 +0200

    Merge remote-tracking branch 'origin/master'

commit de575c1
Author: sebm253 <[email protected]>
Date:   Thu Jun 12 22:51:34 2025 +0200

    Add AttachmentID to UnfurledMediaItem

    discord/discord-api-docs#7611
@Qjuh Qjuh mentioned this pull request Oct 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonydiscord anthonydiscord anthonydiscord approved these changes

+1 more reviewer

@kpodp0ra kpodp0ra kpodp0ra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lulalaby @kpodp0ra @anthonydiscord