Skip to content

Introduce getDiffProps for <View> (#45552) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
May 14, 2025
Merged

Introduce getDiffProps for <View> (#45552) #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ...components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,25 @@ SharedDebugStringConvertibleList HostPlatformViewProps::getDebugProps() const {
}
#endif

#ifdef ANDROID

folly::dynamic HostPlatformViewProps::getDiffProps(
const Props* prevProps) const {
folly::dynamic result = folly::dynamic::object();

static const auto defaultProps = HostPlatformViewProps();

const HostPlatformViewProps* oldProps = prevProps == nullptr
? &defaultProps
: static_cast<const HostPlatformViewProps*>(prevProps);

if (focusable != oldProps->focusable) {
result["focusable"] = focusable;
}

return result;
}

#endif

} // namespace facebook::react
6 changes: 6 additions & 0 deletions ...r/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ class HostPlatformViewProps : public BaseViewProps {
#if RN_DEBUG_STRING_CONVERTIBLE
SharedDebugStringConvertibleList getDebugProps() const override;
#endif

#ifdef ANDROID

folly::dynamic getDiffProps(const Props* prevProps) const override;

#endif
};

} // namespace facebook::react
Loading