Skip to content

[mix_library] allow env vars to be set during compilation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denbeigh2000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[mix_library] allow env vars to be set during compilation #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions private/mix_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,10 @@ def _mix_library_impl(ctx):
erl_libs_dir,
)

# TODO: do we want to expose env vars here?
env = ""
# env = "\n".join([
# "export {}={}".format(k, v)
# for k, v in ctx.attr.env.items()
# ])
env = "\n".join([
"export {}={}".format(k, v)
for k, v in ctx.attr.env.items()
])

(erlang_home, _, erlang_runfiles) = erlang_dirs(ctx)
(elixir_home, elixir_runfiles) = elixir_dirs(ctx)
Expand Down Expand Up @@ -201,7 +199,7 @@ fi
build_dir = ctx.file.mix_config.dirname,
name = ctx.label.name,
mix_env = ctx.attr.mix_env,
# env = env,
env = env,
# setup = ctx.attr.setup,
out_dir = ebin.path,
priv_out_dir = priv_dir.path if priv_dir else "",
Expand Down Expand Up @@ -290,6 +288,7 @@ mix_library = rule(
values = ["prod", "test", "dev"],
doc = "The MIX_ENV to use when compiling (default: prod)",
),
"env": attr.string_dict(),
"mix_config": attr.label(
allow_single_file = [".exs"],
default = ":mix.exs",
Expand Down
Loading