fix: export missing properties and use interfaces on GatewayActivityAssets#1519
Open
AsadHumayun wants to merge 3 commits intodiscordjs:mainfrom
Open
fix: export missing properties and use interfaces on GatewayActivityAssets#1519AsadHumayun wants to merge 3 commits intodiscordjs:mainfrom
AsadHumayun wants to merge 3 commits intodiscordjs:mainfrom
Conversation
AsadHumayun
requested review from
Jiralite,
almeidx,
iCrawl,
sdanialraza and
vladfrangu
|
@AsadHumayun is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
almeidx
requested changes
Feb 8, 2026
Member
almeidx
left a comment
almeidx
left a comment
There was a problem hiding this comment.
Can you make these changes to v9 too?
Author
|
I've added those changes to v9 |
almeidx
approved these changes
Feb 8, 2026
Qjuh
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR will add a missing property to the
GatewayActivityAssetstype, and will use an interface onGatewayActivityAssets, andGatewayActivitySecrets.Tests were run through
npm run test:typesand are passing.If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
Activity Assets, Activity Secrets
Successful merge of this PR will unblock discordjs/discord.js#11411.
Closes #1517