Skip to content

fix(ApplicationCommand): remove false negatives in equals #10596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ApplicationCommand): remove false negatives in equals #10596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/discord.js/src/structures/ApplicationCommand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const { DiscordSnowflake } = require('@sapphire/snowflake');
const { ApplicationCommandOptionType } = require('discord-api-types/v10');
const { ApplicationCommandOptionType, ApplicationIntegrationType } = require('discord-api-types/v10');
const isEqual = require('fast-deep-equal');
const { ApplicationCommandPermissionsManager } = require('../managers/ApplicationCommandPermissionsManager.js');
const { PermissionsBitField } = require('../util/PermissionsBitField.js');
Expand Down Expand Up @@ -445,7 +445,18 @@ class ApplicationCommand extends Base {
command.descriptionLocalizations ?? command.description_localizations ?? {},
this.descriptionLocalizations ?? {},
) ||
!isEqual(command.integrationTypes ?? command.integration_types ?? [], this.integrationTypes ?? []) ||
// [0] is the default value sent by Discord
!isEqual(
command.integrationTypes ??
command.integration_types ??
(this.client.application.integrationTypesConfig
? Object.keys(this.client.application.integrationTypesConfig)
: [ApplicationIntegrationType.GuildInstall]),
this.integrationTypes ??
(this.client.application.integrationTypesConfig
? Object.keys(this.client.application.integrationTypesConfig)
: [ApplicationIntegrationType.GuildInstall]),
) ||
!isEqual(command.contexts ?? [], this.contexts ?? []) ||
('handler' in command && command.handler !== this.handler)
) {
Expand Down