Skip to content

fix: improve handling of italics in the presence of links #11064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: improve handling of italics in the presence of links #11064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35ec807
fix(formatters): don't escape * in links
KTibow Aug 26, 2025
30ef6f6
add test for * -> * in url
KTibow Aug 26, 2025
92c8e72
`\S+` -> `\S*` (tested locally)
KTibow Aug 26, 2025
1a1eb11
@Qjuh: handle italics both inside+outside <url>s
KTibow Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/formatters/__tests__/escapers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ const testURLs = [
'https://example.com/name_with_underscores',
'https://example.com/name__with__underscores',
'https://example.com/name_with_underscores_and__double__underscores',
'https://*.example.com/globbed/*',
'https://example.com/*before*/>/*after*',
];

describe('Markdown escapers', () => {
Expand Down Expand Up @@ -87,6 +89,16 @@ describe('Markdown escapers', () => {
test('url', () => {
for (const url of testURLs) expect(escapeItalic(url)).toBe(url);
});

test('after-url', () => {
const url = '<https://example.com>';
for (const [input, output] of [
['*hi*', '\\*hi\\*'],
['_hi_', '\\_hi\\_'],
]) {
expect(escapeItalic(url + input)).toBe(url + output);
}
});
});

describe('escapeUnderline', () => {
Expand Down
22 changes: 14 additions & 8 deletions packages/formatters/src/escapers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,21 @@ export function escapeInlineCode(text: string): string {
*/
export function escapeItalic(text: string): string {
let idx = 0;
const newText = text.replaceAll(/(?<=^|[^*])\*([^*]|\*\*|$)/g, (_, match) => {
if (match === '**') return ++idx % 2 ? `\\*${match}` : `${match}\\*`;
return `\\*${match}`;
});
const newText = text.replaceAll(
/(?<=^|[^*])(?<!(?<!<)https?:\/\/\S*|<https?:\/\/[^\s>]*)\*([^*]|\*\*|$)/g,
(_, match) => {
if (match === '**') return ++idx % 2 ? `\\*${match}` : `${match}\\*`;
return `\\*${match}`;
},
);
idx = 0;
return newText.replaceAll(/(?<=^|[^_])(?<!<a?:.+|https?:\/\/\S+)_(?!:\d+>)([^_]|__|$)/g, (_, match) => {
if (match === '__') return ++idx % 2 ? `\\_${match}` : `${match}\\_`;
return `\\_${match}`;
});
return newText.replaceAll(
/(?<=^|[^_])(?<!<a?:.+|(?<!<)https?:\/\/\S*|<https?:\/\/[^\s>]*)_(?!:\d+>)([^_]|__|$)/g,
(_, match) => {
if (match === '__') return ++idx % 2 ? `\\_${match}` : `${match}\\_`;
return `\\_${match}`;
},
);
}

/**
Expand Down