-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(voice): Add info about DAVE protocol dependencies and support #11145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 3 commits into
discordjs:main
from
jNullj:update-voice-guide-encryption-dependencies
Oct 11, 2025
Merged
feat(voice): Add info about DAVE protocol dependencies and support #11145
kodiakhq
merged 3 commits into
discordjs:main
from
jNullj:update-voice-guide-encryption-dependencies
Oct 11, 2025
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiralite
approved these changes
Oct 6, 2025
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
almeidx
previously requested changes
Oct 7, 2025
Qjuh
approved these changes
Oct 11, 2025
Changes remade from discordjs/guide#1630 due to project moving from that repo to this one.
Co-authored-by: Almeida <[email protected]>
814a517
to
96e7995
Compare
almeidx
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Changes remade from discordjs/guide#1630 due to project moving from that repo to this one.
Seems that we might need a few updates here for the voice guides.
generateDependencyReport
output in the guide.@snazzah/davey
being a dev dependency, this could confuse some devs.node:crypto
, updated the section about the requirement to install encryption library and a tip to verify the system support.Support for DAVE protocol was added here #10735
Please note that I discovered this while I got repeated crashes due to discord not downgrading my connection to a non e2ee connection!
Discord mention this in a past blog post here and it seems like this is about to be a requirement.
Created PR #11061 to update voice package readme as well.
Status and versioning classification: