Skip to content

Conversation

jNullj
Copy link
Contributor

@jNullj jNullj commented Oct 6, 2025

Please describe the changes this PR makes and why it should be merged:

Changes remade from discordjs/guide#1630 due to project moving from that repo to this one.

Seems that we might need a few updates here for the voice guides.

  • There is support for the DAVE protocol, some users might be interested and it should show as an option.
  • Same goes for generateDependencyReport output in the guide.
  • Added warning about @snazzah/davey being a dev dependency, this could confuse some devs.
  • We now support node:crypto, updated the section about the requirement to install encryption library and a tip to verify the system support.

Support for DAVE protocol was added here #10735
Please note that I discovered this while I got repeated crashes due to discord not downgrading my connection to a non e2ee connection!
Discord mention this in a past blog post here and it seems like this is about to be a requirement.

Created PR #11061 to update voice package readme as well.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@jNullj jNullj requested review from a team as code owners October 6, 2025 16:37
@jNullj jNullj requested review from Jiralite, Qjuh, almeidx and iCrawl October 6, 2025 16:37
@jNullj jNullj requested a review from monbrey October 6, 2025 16:37
@Jiralite Jiralite changed the title guide(voice): Add info about DAVE protocol dependencies and support feat(voice): Add info about DAVE protocol dependencies and support Oct 6, 2025
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ready Ready Preview Comment Oct 11, 2025 11:31am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 11, 2025 11:31am

almeidx
almeidx previously requested changes Oct 7, 2025
@Jiralite Jiralite force-pushed the update-voice-guide-encryption-dependencies branch from 814a517 to 96e7995 Compare October 11, 2025 11:28
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Oct 11, 2025
@kodiakhq kodiakhq bot merged commit 180dd60 into discordjs:main Oct 11, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants