Skip to content

Conversation

didinele
Copy link
Member

@didinele didinele commented Oct 7, 2025

Closes #11150

Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js Ready Ready Preview Comment Oct 8, 2025 10:14am
discord-js-guide Ready Ready Preview Comment Oct 8, 2025 10:14am

@didinele didinele requested a review from Jiralite October 7, 2025 07:57
@Jiralite Jiralite added the chore label Oct 7, 2025
@didinele didinele force-pushed the chore/update-badge branch from 9b814f6 to c4ab523 Compare October 7, 2025 08:00
almeidx
almeidx previously requested changes Oct 7, 2025
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Discord server badge is also included in the readme's of packages, e.g.

<a href="https://discord.gg/djs"><img src="https://img.shields.io/discord/222078108977594368?color=5865F2&logo=discord&logoColor=white" alt="Discord server" /></a>

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Oct 7, 2025
@didinele didinele requested review from a team as code owners October 8, 2025 10:13
@didinele didinele requested review from kyranet and vladfrangu October 8, 2025 10:13
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.31%. Comparing base (985b525) to head (daf9d54).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11152      +/-   ##
==========================================
+ Coverage   44.26%   44.31%   +0.04%     
==========================================
  Files         313      313              
  Lines       18064    18044      -20     
  Branches     1796     1796              
==========================================
  Hits         7996     7996              
+ Misses      10056    10036      -20     
  Partials       12       12              
Flag Coverage Δ
core 0.91% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@almostSouji
Copy link
Member

almostSouji commented Oct 13, 2025

Can't we use a static badge with the vanity invite instead of removing the discord invite fully?

After some attempts of playing around with it, seems decent?

https://img.shields.io/badge/join_us-on_discord-5865F2?logo=discord&logoColor=white
https://img.shields.io/badge/join_us-on_discord-5865F2?logo=discord

@Jiralite
Copy link
Member

That could work. Just dropping the link here: https://shields.io/badges/static-badge

We could keep both badges this way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

Update the Discord widget badge

6 participants